From: trondmy@kernel.org
To: Anna Schumaker <anna.schumaker@netapp.com>
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH v3 1/5] NFS: Do not report EINTR/ERESTARTSYS as mapping errors
Date: Sat, 14 May 2022 10:27:00 -0400 [thread overview]
Message-ID: <20220514142704.4149-2-trondmy@kernel.org> (raw)
In-Reply-To: <20220514142704.4149-1-trondmy@kernel.org>
From: Trond Myklebust <trond.myklebust@hammerspace.com>
If the attempt to flush data was interrupted due to a local signal, then
just requeue the writes back for I/O.
Fixes: 6fbda89b257f ("NFS: Replace custom error reporting mechanism with generic one")
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
---
fs/nfs/write.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nfs/write.c b/fs/nfs/write.c
index a8eb348947a6..ce4cc4222422 100644
--- a/fs/nfs/write.c
+++ b/fs/nfs/write.c
@@ -1441,7 +1441,7 @@ static void nfs_async_write_error(struct list_head *head, int error)
while (!list_empty(head)) {
req = nfs_list_entry(head->next);
nfs_list_remove_request(req);
- if (nfs_error_is_fatal(error))
+ if (nfs_error_is_fatal_on_server(error))
nfs_write_error(req, error);
else
nfs_redirty_request(req);
--
2.36.1
next prev parent reply other threads:[~2022-05-14 14:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-14 14:26 [PATCH v3 0/5] Ensure mapping errors are reported only once trondmy
2022-05-14 14:27 ` trondmy [this message]
2022-05-14 14:27 ` [PATCH v3 2/5] NFS: fsync() should report filesystem errors over EINTR/ERESTARTSYS trondmy
2022-05-14 14:27 ` [PATCH v3 3/5] NFS: Don't report ENOSPC write errors twice trondmy
2022-05-14 14:27 ` [PATCH v3 4/5] NFS: Do not report flush errors in nfs_write_end() trondmy
2022-05-14 14:27 ` [PATCH v3 5/5] NFS: Don't report errors from nfs_pageio_complete() more than once trondmy
2022-06-15 2:36 ` [PATCH v3 3/5] NFS: Don't report ENOSPC write errors twice chenxiaosong (A)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220514142704.4149-2-trondmy@kernel.org \
--to=trondmy@kernel.org \
--cc=anna.schumaker@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).