From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D581C433EF for ; Fri, 20 May 2022 03:59:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229979AbiETD7k (ORCPT ); Thu, 19 May 2022 23:59:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229809AbiETD7j (ORCPT ); Thu, 19 May 2022 23:59:39 -0400 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0551B41FB; Thu, 19 May 2022 20:59:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653019178; x=1684555178; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=wFKsShW4JICrygY8XRlIokt1kXFF5Vhlbt6wSyHgbz0=; b=YZeGY+bTElKf5HH0ul/berlzMM+cFhOWqpVr1+u87scpSaHrFbOtoo+V JjZdg+Hq2IMvEOgHNGrx3vF5yVjwmrZYVOx3Ll73lDdFqWVSqi0zwMe5I qjHdLdXp1U+b/RMJHKJEOAKiMkXYkhTJvycQYFE5Dp6ZgIdXKocdIN7ZD M8hKWiSHvfi3AmF/fQfg1UrJShaC44I5/T98swDWB7fyTyeUvTjIXWj7O sfQWEZMF0Hfd+cCwjjy19ZOkPjM9IX3x+Dc9RGxFRIPE6hWfhnjtX+vL7 Dc27IaWia+F7aAL9PDuL5zvGjAuzVPNhXg64l5L8ph7i3gfbIFhcF4OwV A==; X-IronPort-AV: E=McAfee;i="6400,9594,10352"; a="272180578" X-IronPort-AV: E=Sophos;i="5.91,238,1647327600"; d="scan'208";a="272180578" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2022 20:59:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,238,1647327600"; d="scan'208";a="662067436" Received: from lkp-server02.sh.intel.com (HELO 242b25809ac7) ([10.239.97.151]) by FMSMGA003.fm.intel.com with ESMTP; 19 May 2022 20:59:36 -0700 Received: from kbuild by 242b25809ac7 with local (Exim 4.95) (envelope-from ) id 1nrtnb-0004GJ-FW; Fri, 20 May 2022 03:59:35 +0000 Date: Fri, 20 May 2022 11:58:46 +0800 From: kernel test robot To: Javier Abrego , trond.myklebust@hammerspace.com, anna@kernel.org Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, javier.abrego.lorente@gmail.com Subject: Re: [PATCH] FS: nfs: removed goto statement Message-ID: <202205201106.ONDKuLvW-lkp@intel.com> References: <20220519225115.35431-1-javier.abrego.lorente@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220519225115.35431-1-javier.abrego.lorente@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Hi Javier, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on trondmy-nfs/linux-next] [also build test WARNING on v5.18-rc7 next-20220519] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Javier-Abrego/FS-nfs-removed-goto-statement/20220520-065648 base: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next config: i386-randconfig-a015 (https://download.01.org/0day-ci/archive/20220520/202205201106.ONDKuLvW-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project e00cbbec06c08dc616a0d52a20f678b8fbd4e304) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/99dd76e4af5d61f97c1981a240cbd1d86908ac8e git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Javier-Abrego/FS-nfs-removed-goto-statement/20220520-065648 git checkout 99dd76e4af5d61f97c1981a240cbd1d86908ac8e # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash fs/nfs/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> fs/nfs/nfs42xattr.c:754:3: warning: variable 'entry' is uninitialized when used here [-Wuninitialized] entry->bucket = &cache->buckets[0]; ^~~~~ fs/nfs/nfs42xattr.c:743:32: note: initialize the variable 'entry' to silence this warning struct nfs4_xattr_entry *entry; ^ = NULL 1 warning generated. vim +/entry +754 fs/nfs/nfs42xattr.c 95ad37f90c338e Frank van der Linden 2020-06-23 735 95ad37f90c338e Frank van der Linden 2020-06-23 736 /* 95ad37f90c338e Frank van der Linden 2020-06-23 737 * Cache listxattr output, replacing any possible old one. 95ad37f90c338e Frank van der Linden 2020-06-23 738 */ 95ad37f90c338e Frank van der Linden 2020-06-23 739 void nfs4_xattr_cache_set_list(struct inode *inode, const char *buf, 95ad37f90c338e Frank van der Linden 2020-06-23 740 ssize_t buflen) 95ad37f90c338e Frank van der Linden 2020-06-23 741 { 95ad37f90c338e Frank van der Linden 2020-06-23 742 struct nfs4_xattr_cache *cache; 95ad37f90c338e Frank van der Linden 2020-06-23 743 struct nfs4_xattr_entry *entry; 95ad37f90c338e Frank van der Linden 2020-06-23 744 95ad37f90c338e Frank van der Linden 2020-06-23 745 cache = nfs4_xattr_get_cache(inode, 1); 99dd76e4af5d61 Javier Abrego 2022-05-20 746 if (cache == NULL) { 99dd76e4af5d61 Javier Abrego 2022-05-20 747 kref_put(&cache->ref, nfs4_xattr_free_cache_cb); 99dd76e4af5d61 Javier Abrego 2022-05-20 748 } else { 95ad37f90c338e Frank van der Linden 2020-06-23 749 /* 95ad37f90c338e Frank van der Linden 2020-06-23 750 * This is just there to be able to get to bucket->cache, 95ad37f90c338e Frank van der Linden 2020-06-23 751 * which is obviously the same for all buckets, so just 95ad37f90c338e Frank van der Linden 2020-06-23 752 * use bucket 0. 95ad37f90c338e Frank van der Linden 2020-06-23 753 */ 95ad37f90c338e Frank van der Linden 2020-06-23 @754 entry->bucket = &cache->buckets[0]; 95ad37f90c338e Frank van der Linden 2020-06-23 755 95ad37f90c338e Frank van der Linden 2020-06-23 756 if (!nfs4_xattr_set_listcache(cache, entry)) 95ad37f90c338e Frank van der Linden 2020-06-23 757 kref_put(&entry->ref, nfs4_xattr_free_entry_cb); 99dd76e4af5d61 Javier Abrego 2022-05-20 758 } 95ad37f90c338e Frank van der Linden 2020-06-23 759 } 95ad37f90c338e Frank van der Linden 2020-06-23 760 -- 0-DAY CI Kernel Test Service https://01.org/lkp