From: Jeff Layton <jlayton@kernel.org>
To: trond.myklebust@hammerspace.com, anna@kernel.org
Cc: linux-nfs@vger.kernel.org, chuck.lever@oracle.com, bxue@redhat.com
Subject: [PATCH 0/3] nfs: fix -ENOSPC DIO write regression
Date: Fri, 22 Jul 2022 14:12:17 -0400 [thread overview]
Message-ID: <20220722181220.81636-1-jlayton@kernel.org> (raw)
Boyang reported that xfstest generic/476 would never complete when run
against a filesystem that was "too small".
What I found was that we would end up trying to issue a large DIO write
that would come back short. The kernel would then follow up and try to
write out the rest and get back -ENOSPC. It would then try to issue a
commit, which would then try to reissue the writes, and around it would
go.
This patchset seems to fix it. Unfortunately, I'm not positive which
patch _broke_ this as it seems to have happened quite some time ago.
Jeff Layton (3):
nfs: add new nfs_direct_req tracepoint events
nfs: always check dreq->error after a commit
nfs: only issue commit in DIO codepath if we have uncommitted data
fs/nfs/direct.c | 50 +++++++++--------------------
fs/nfs/internal.h | 33 ++++++++++++++++++++
fs/nfs/nfstrace.h | 69 +++++++++++++++++++++++++++++++++++++++++
fs/nfs/write.c | 48 +++++++++++++++++-----------
include/linux/nfs_xdr.h | 1 +
5 files changed, 148 insertions(+), 53 deletions(-)
--
2.36.1
next reply other threads:[~2022-07-22 18:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 18:12 Jeff Layton [this message]
2022-07-22 18:12 ` [PATCH 1/3] nfs: add new nfs_direct_req tracepoint events Jeff Layton
2022-07-22 18:12 ` [PATCH 2/3] nfs: always check dreq->error after a commit Jeff Layton
2022-07-22 18:12 ` [PATCH 3/3] nfs: only issue commit in DIO codepath if we have uncommitted data Jeff Layton
2022-07-24 19:10 ` [PATCH 0/3] nfs: fix -ENOSPC DIO write regression Trond Myklebust
2022-07-24 20:18 ` Trond Myklebust
2022-08-04 8:54 ` Boyang Xue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220722181220.81636-1-jlayton@kernel.org \
--to=jlayton@kernel.org \
--cc=anna@kernel.org \
--cc=bxue@redhat.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).