linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: chuck.lever@oracle.com
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 0/4] nfsd: minor cleanup and sanity check patches for nfsd
Date: Mon, 26 Sep 2022 12:38:43 -0400	[thread overview]
Message-ID: <20220926163847.47558-1-jlayton@kernel.org> (raw)

Chuck,

While hunting for some bugs, I found some warts that the first two
patches clean up. I also added some sanity checks when freeing
delegations or queueing up a CB_RECALL. Your call on whether you want
to accept those. These should apply cleanly to your for-next branch,
but the last patch may need to be adjusted when Dai fixes up his patch.

Cheers,

Jeff Layton (4):
  nfsd: only fill out return pointer on success in nfsd4_lookup_stateid
  nfsd: fix comments about spinlock handling with delegations
  nfsd: make nfsd4_run_cb a bool return function
  nfsd: extra checks when freeing delegation stateids

 fs/nfsd/nfs4callback.c | 14 ++++++++++++--
 fs/nfsd/nfs4state.c    | 26 +++++++++++++++-----------
 fs/nfsd/state.h        |  2 +-
 3 files changed, 28 insertions(+), 14 deletions(-)

-- 
2.37.3


             reply	other threads:[~2022-09-26 17:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-26 16:38 Jeff Layton [this message]
2022-09-26 16:38 ` [PATCH 1/4] nfsd: only fill out return pointer on success in nfsd4_lookup_stateid Jeff Layton
2022-09-26 16:38 ` [PATCH 2/4] nfsd: fix comments about spinlock handling with delegations Jeff Layton
2022-09-26 16:38 ` [PATCH 3/4] nfsd: make nfsd4_run_cb a bool return function Jeff Layton
2022-09-26 17:51   ` Chuck Lever III
2022-09-26 18:24     ` Jeff Layton
2022-09-26 18:31       ` Chuck Lever III
2022-09-26 16:38 ` [PATCH 4/4] nfsd: extra checks when freeing delegation stateids Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220926163847.47558-1-jlayton@kernel.org \
    --to=jlayton@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).