From: Jeff Layton <jlayton@kernel.org>
To: chuck.lever@oracle.com
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 0/3] nfsd: filecache fixes
Date: Fri, 30 Sep 2022 15:15:47 -0400 [thread overview]
Message-ID: <20220930191550.172087-1-jlayton@kernel.org> (raw)
I've been trying to hunt down the bug reported here:
https://bugzilla.linux-nfs.org/show_bug.cgi?id=394
I've not been able to reliably reproduce that, but patches #2 and #3 may
help. The issue I think may be in the management of the sentinel
reference. Responsibility for putting that reference belongs to the
task that clears the HASHED flag, so we need to take care not to put
that ref until we've successfully cleared it.
Hopefully, this will make it a bit more consistent (and close some other
potential races as well).
Jeff Layton (3):
nfsd: nfsd_do_file_acquire should hold rcu_read_lock while getting
refs
nfsd: fix potential race in nfsd_file_close
nfsd: fix nfsd_file_unhash_and_dispose
fs/nfsd/filecache.c | 53 ++++++++++++++++++---------------------------
1 file changed, 21 insertions(+), 32 deletions(-)
--
2.37.3
next reply other threads:[~2022-09-30 19:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 19:15 Jeff Layton [this message]
2022-09-30 19:15 ` [PATCH 1/3] nfsd: nfsd_do_file_acquire should hold rcu_read_lock while getting refs Jeff Layton
2022-09-30 19:20 ` Chuck Lever III
2022-09-30 19:33 ` Jeff Layton
2022-09-30 20:06 ` Chuck Lever III
2022-10-01 4:44 ` NeilBrown
2022-10-01 9:47 ` Jeff Layton
2022-09-30 19:15 ` [PATCH 2/3] nfsd: fix potential race in nfsd_file_close Jeff Layton
2022-09-30 20:58 ` Jeff Layton
2022-09-30 20:59 ` Chuck Lever III
2022-10-01 5:03 ` NeilBrown
2022-10-01 9:55 ` Jeff Layton
2022-09-30 19:15 ` [PATCH 3/3] nfsd: fix nfsd_file_unhash_and_dispose Jeff Layton
2022-09-30 19:29 ` Chuck Lever III
2022-09-30 19:42 ` Jeff Layton
2022-09-30 20:23 ` Chuck Lever III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220930191550.172087-1-jlayton@kernel.org \
--to=jlayton@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).