From: Guillaume Nault <gnault@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna@kernel.org>,
Chuck Lever <chuck.lever@oracle.com>,
Jeff Layton <jlayton@kernel.org>,
linux-nfs@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
Benjamin Coddington <bcodding@redhat.com>
Subject: Re: [PATCH v2] sunrpc: Use GFP_NOFS to prevent use of current->task_frag.
Date: Tue, 11 Oct 2022 17:00:57 +0200 [thread overview]
Message-ID: <20221011150057.GB3606@localhost.localdomain> (raw)
In-Reply-To: <Y0UKq62ByUGNQpuY@infradead.org>
On Mon, Oct 10, 2022 at 11:18:19PM -0700, Christoph Hellwig wrote:
> On Mon, Oct 10, 2022 at 06:56:50PM +0200, Guillaume Nault wrote:
> > That's what my RFC patch did. It was rejected because reading
> > current->flags may incur a cache miss thus slowing down TCP fast path.
> > See the discussion in the Link tag:
> > https://lore.kernel.org/netdev/b4d8cb09c913d3e34f853736f3f5628abfd7f4b6.1656699567.git.gnault@redhat.com/
>
> As GFP_NOFS/NOIO are on their way out the networking people will have to
> do this anyway.
We can always think of a nicer solution in the future. But right now we
have a real bug to fix.
Commit a1231fda7e94 ("SUNRPC: Set memalloc_nofs_save() on all
rpciod/xprtiod jobs") introduces a bug that crashes the kernel. I can't
see anything wrong with a partial revert.
next prev parent reply other threads:[~2022-10-11 15:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 11:41 [PATCH v2] sunrpc: Use GFP_NOFS to prevent use of current->task_frag Guillaume Nault
2022-10-10 14:55 ` Christoph Hellwig
2022-10-10 16:56 ` Guillaume Nault
2022-10-11 6:18 ` Christoph Hellwig
2022-10-11 15:00 ` Guillaume Nault [this message]
2022-10-11 15:57 ` Trond Myklebust
2022-10-11 21:14 ` Guillaume Nault
2022-10-13 12:18 ` Guillaume Nault
2022-10-25 11:15 ` Guillaume Nault
2022-12-07 11:47 ` Benjamin Coddington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221011150057.GB3606@localhost.localdomain \
--to=gnault@redhat.com \
--cc=anna@kernel.org \
--cc=bcodding@redhat.com \
--cc=chuck.lever@oracle.com \
--cc=hch@infradead.org \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox