public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: chuck.lever@oracle.com
Cc: linux-nfs@vger.kernel.org, neilb@suse.de
Subject: [PATCH v2 3/3] nfsd: start non-blocking writeback after adding nfsd_file to the LRU
Date: Thu, 27 Oct 2022 17:52:13 -0400	[thread overview]
Message-ID: <20221027215213.138304-4-jlayton@kernel.org> (raw)
In-Reply-To: <20221027215213.138304-1-jlayton@kernel.org>

When a GC entry gets added to the LRU, kick off SYNC_NONE writeback
so that we can be ready to close it out when the time comes.

Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
 fs/nfsd/filecache.c | 37 +++++++++++++++++++++++++++++++------
 1 file changed, 31 insertions(+), 6 deletions(-)

diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c
index d2bbded805d4..491d3d9a1870 100644
--- a/fs/nfsd/filecache.c
+++ b/fs/nfsd/filecache.c
@@ -316,7 +316,7 @@ nfsd_file_alloc(struct nfsd_file_lookup_key *key, unsigned int may)
 }
 
 static void
-nfsd_file_flush(struct nfsd_file *nf)
+nfsd_file_fsync(struct nfsd_file *nf)
 {
 	struct file *file = nf->nf_file;
 
@@ -327,6 +327,22 @@ nfsd_file_flush(struct nfsd_file *nf)
 		nfsd_reset_write_verifier(net_generic(nf->nf_net, nfsd_net_id));
 }
 
+static void
+nfsd_file_flush(struct nfsd_file *nf)
+{
+	struct file *file = nf->nf_file;
+	unsigned long nrpages;
+
+	if (!file || !(file->f_mode & FMODE_WRITE))
+		return;
+
+	nrpages = file->f_mapping->nrpages;
+	if (nrpages) {
+		this_cpu_add(nfsd_file_pages_flushed, nrpages);
+		filemap_flush(file->f_mapping);
+	}
+}
+
 static void
 nfsd_file_free(struct nfsd_file *nf)
 {
@@ -337,7 +353,7 @@ nfsd_file_free(struct nfsd_file *nf)
 	this_cpu_inc(nfsd_file_releases);
 	this_cpu_add(nfsd_file_total_age, age);
 
-	nfsd_file_flush(nf);
+	nfsd_file_fsync(nf);
 
 	if (nf->nf_mark)
 		nfsd_file_mark_put(nf->nf_mark);
@@ -500,12 +516,21 @@ nfsd_file_put(struct nfsd_file *nf)
 
 	if (test_bit(NFSD_FILE_GC, &nf->nf_flags)) {
 		/*
-		 * If this is the last reference (nf_ref == 1), then transfer
-		 * it to the LRU. If the add to the LRU fails, just put it as
-		 * usual.
+		 * If this is the last reference (nf_ref == 1), then try
+		 * to transfer it to the LRU.
+		 */
+		if (refcount_dec_not_one(&nf->nf_ref))
+			return;
+
+		/*
+		 * If the add to the list succeeds, try to kick off SYNC_NONE
+		 * writeback. If the add fails, then just fall through to
+		 * decrement as usual.
 		 */
-		if (refcount_dec_not_one(&nf->nf_ref) || nfsd_file_lru_add(nf))
+		if (nfsd_file_lru_add(nf)) {
+			nfsd_file_flush(nf);
 			return;
+		}
 	}
 	__nfsd_file_put(nf);
 }
-- 
2.37.3


  parent reply	other threads:[~2022-10-27 21:52 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-27 21:52 [PATCH v2 0/3] nfsd: clean up refcounting in filecache Jeff Layton
2022-10-27 21:52 ` [PATCH v2 1/3] nfsd: rework " Jeff Layton
2022-10-27 22:51   ` NeilBrown
2022-10-28  9:57     ` Jeff Layton
2022-10-28 22:14       ` NeilBrown
2022-10-30 21:29         ` NeilBrown
2022-10-31  9:58           ` Jeff Layton
2022-10-31  9:54         ` Jeff Layton
2022-10-27 21:52 ` [PATCH v2 2/3] nfsd: only keep unused entries on the LRU Jeff Layton
2022-10-27 22:20   ` NeilBrown
2022-10-27 22:47     ` Jeff Layton
2022-10-27 22:55       ` NeilBrown
2022-10-27 23:52         ` Chuck Lever III
2022-10-27 21:52 ` Jeff Layton [this message]
2022-10-27 22:25   ` [PATCH v2 3/3] nfsd: start non-blocking writeback after adding nfsd_file to " NeilBrown
2022-10-28 13:01     ` Jeff Layton
2022-10-28 13:16   ` Chuck Lever III
2022-10-28 15:05     ` Jeff Layton
2022-10-28 15:29       ` Chuck Lever III
2022-10-28 15:51         ` Jeff Layton
2022-10-28 17:21           ` Chuck Lever III
2022-10-28 17:43             ` Jeff Layton
2022-10-28 18:53               ` Chuck Lever III
2022-10-28 20:04                 ` Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221027215213.138304-4-jlayton@kernel.org \
    --to=jlayton@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox