public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Chuck Lever <chuck.lever@oracle.com>,
	Trond Myklebust <trond.myklebust@hammerspace.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-nfs@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: Files in include/trace/events
Date: Sat, 12 Nov 2022 07:33:05 -0500	[thread overview]
Message-ID: <20221112073305.0346b827@rorschach.local.home> (raw)
In-Reply-To: <20221112072742.065df70a@rorschach.local.home>

On Sat, 12 Nov 2022 07:27:42 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> Hi Chuck,
> 
> I was just looking over some files in include/trace/events/ and noticed
> that there's sunrpc_base.h, fs.h and nfs.h that are not event files.
> 
> The include/trace/events/ directory should only hold files that are to
> create events, not headers that hold helper functions.
> 
> Can you please move them out of include/trace/events/ as that directory
> is "special" in the creation of events.
> 
> Perhaps we could create a new directory include/linux/trace/ or
> include/trace/linux/ specific for these types of files?
> 

Hi Vlastimil,

I also noticed that mmflags.h is in that directory too.

I'd like to keep only headers defining TRACE_EVENT() in that directory,
as files there have special meaning.

Thanks,

-- Steve

  reply	other threads:[~2022-11-12 12:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-12 12:27 Files in include/trace/events Steven Rostedt
2022-11-12 12:33 ` Steven Rostedt [this message]
2022-11-22 10:23   ` Vlastimil Babka
2022-11-12 15:57 ` Chuck Lever III

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221112073305.0346b827@rorschach.local.home \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=chuck.lever@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=trond.myklebust@hammerspace.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox