From: Richard Weinberger <richard@nod.at>
To: linux-nfs@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
jlayton@kernel.org, chuck.lever@oracle.com, anna@kernel.org,
trond.myklebust@hammerspace.com, viro@zeniv.linux.org.uk,
raven@themaw.net, chris.chilvers@appsbroker.com,
david.young@appsbroker.com, luis.turcitu@appsbroker.com,
david@sigma-star.at, benmaynard@google.com,
Richard Weinberger <richard@nod.at>
Subject: [PATCH 2/3] fs: namei: Allow follow_down() to uncover auto mounts
Date: Wed, 7 Dec 2022 09:43:08 +0100 [thread overview]
Message-ID: <20221207084309.8499-3-richard@nod.at> (raw)
In-Reply-To: <20221207084309.8499-1-richard@nod.at>
This function is only used by NFSD to cross mount points.
If a mount point is of type auto mount, follow_down() will
not uncover it. Add LOOKUP_AUTOMOUNT to the lookup flags
to have ->d_automount() called when NFSD walks down the
mount tree.
Signed-off-by: Richard Weinberger <richard@nod.at>
---
fs/namei.c | 6 +++---
fs/nfsd/vfs.c | 6 +++++-
include/linux/namei.h | 2 +-
3 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/fs/namei.c b/fs/namei.c
index 578c2110df02..a6bb6863bf0c 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -1458,11 +1458,11 @@ EXPORT_SYMBOL(follow_down_one);
* point, the filesystem owning that dentry may be queried as to whether the
* caller is permitted to proceed or not.
*/
-int follow_down(struct path *path)
+int follow_down(struct path *path, unsigned int flags)
{
struct vfsmount *mnt = path->mnt;
bool jumped;
- int ret = traverse_mounts(path, &jumped, NULL, 0);
+ int ret = traverse_mounts(path, &jumped, NULL, flags);
if (path->mnt != mnt)
mntput(mnt);
@@ -2864,7 +2864,7 @@ int path_pts(struct path *path)
path->dentry = child;
dput(parent);
- follow_down(path);
+ follow_down(path, 0);
return 0;
}
#endif
diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
index 157f0df0e93a..ced04fc2b947 100644
--- a/fs/nfsd/vfs.c
+++ b/fs/nfsd/vfs.c
@@ -63,9 +63,13 @@ nfsd_cross_mnt(struct svc_rqst *rqstp, struct dentry **dpp,
struct dentry *dentry = *dpp;
struct path path = {.mnt = mntget(exp->ex_path.mnt),
.dentry = dget(dentry)};
+ unsigned int follow_flags = 0;
int err = 0;
- err = follow_down(&path);
+ if (exp->ex_flags & NFSEXP_CROSSMOUNT)
+ follow_flags = LOOKUP_AUTOMOUNT;
+
+ err = follow_down(&path, follow_flags);
if (err < 0)
goto out;
if (path.mnt == exp->ex_path.mnt && path.dentry == dentry &&
diff --git a/include/linux/namei.h b/include/linux/namei.h
index 00fee52df842..6f96db73a70a 100644
--- a/include/linux/namei.h
+++ b/include/linux/namei.h
@@ -77,7 +77,7 @@ struct dentry *lookup_one_positive_unlocked(struct user_namespace *mnt_userns,
struct dentry *base, int len);
extern int follow_down_one(struct path *);
-extern int follow_down(struct path *);
+extern int follow_down(struct path *, unsigned int flags);
extern int follow_up(struct path *);
extern struct dentry *lock_rename(struct dentry *, struct dentry *);
--
2.26.2
next prev parent reply other threads:[~2022-12-07 8:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 8:43 [PATCH 0/3 v2] NFS: NFSD: Allow crossing mounts when re-exporting Richard Weinberger
2022-12-07 8:43 ` [PATCH 1/3] NFSD: Teach nfsd_mountpoint() auto mounts Richard Weinberger
2022-12-07 8:43 ` Richard Weinberger [this message]
2022-12-14 15:15 ` [PATCH 2/3] namei: Allow follow_down() to uncover " Chuck Lever III
2023-01-03 16:15 ` Chuck Lever III
2023-01-29 15:42 ` Richard Weinberger
2023-01-30 2:15 ` Al Viro
2022-12-07 8:43 ` [PATCH 3/3] NFS: nfs_encode_fh: Remove S_AUTOMOUNT check Richard Weinberger
2022-12-14 15:09 ` Chuck Lever III
2022-12-14 16:37 ` Anna Schumaker
2022-12-14 16:39 ` Chuck Lever III
2022-12-10 16:09 ` [PATCH 0/3 v2] NFS: NFSD: Allow crossing mounts when re-exporting Chuck Lever III
2022-12-10 21:52 ` Richard Weinberger
2022-12-10 21:53 ` Chuck Lever III
2022-12-12 17:06 ` Jeff Layton
2022-12-13 9:09 ` Ian Kent
-- strict thread matches above, loose matches on Subject: below --
2022-11-17 19:11 [PATCH 0/3] " Richard Weinberger
2022-11-17 19:11 ` [PATCH 2/3] fs: namei: Allow follow_down() to uncover auto mounts Richard Weinberger
2022-11-17 21:01 ` Jeff Layton
2022-11-17 21:12 ` Richard Weinberger
2022-11-17 21:42 ` Jeff Layton
2022-11-27 21:29 ` Richard Weinberger
2022-11-28 11:49 ` Jeff Layton
2022-11-17 23:37 ` Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221207084309.8499-3-richard@nod.at \
--to=richard@nod.at \
--cc=anna@kernel.org \
--cc=benmaynard@google.com \
--cc=chris.chilvers@appsbroker.com \
--cc=chuck.lever@oracle.com \
--cc=david.young@appsbroker.com \
--cc=david@sigma-star.at \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=luis.turcitu@appsbroker.com \
--cc=raven@themaw.net \
--cc=trond.myklebust@hammerspace.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox