public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: NeilBrown <neilb@suse.de>
To: Chuck Lever <chuck.lever@oracle.com>, Jeff Layton <jlayton@kernel.org>
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 0/7] SUNRPC - queuing improvements.
Date: Fri, 18 Aug 2023 11:45:05 +1000	[thread overview]
Message-ID: <20230818014512.26880-1-neilb@suse.de> (raw)

This series is against topic-sunrpc-thread-scheduling (7fddd9be200c).
There are two changes since last post (other than dropping patches
that have been included in the topic branch.

1/ When I dropped the test on freezing(current), need needed to
   add TASK_FREEZABLE to the wait state.  I could keep testing
   freezing(current) before calling schedule, but TASK_FREEZABLE
   is cleaner and seems to be prefered ... except ...

   /proc/PID/stat reports a status for "D" for tasks that are
      TASK_IDLE | TASK_FREEZABLE
   instead of the correct "I".  I've included a fix for that in
   the relevant patch.  I should probably post is separately
   to the scheduler team.

2/ There was a bug in lwq_dequeue().  It tested lwq_empty() without
   taking the spinlock.  This could result in call-positive results
   if it raced with another lwq_dequeue(). So lwq_dequeue() now
   ensure the queue never looks transiently empty.
   lwq_empty() is also more careful about memory ordering.

NeilBrown

 [PATCH 1/7] SUNRPC: change service idle list to be an llist
 [PATCH 2/7] SUNRPC: only have one thread waking up at a time
 [PATCH 3/7] SUNRPC/svc: add light-weight queuing mechanism.
 [PATCH 4/7] SUNRPC: use lwq for sp_sockets - renamed to sp_xprts
 [PATCH 5/7] SUNRPC: change sp_nrthreads to atomic_t
 [PATCH 6/7] SUNRPC: discard sp_lock
 [PATCH 7/7] SUNRPC: change the back-channel queue to lwq


             reply	other threads:[~2023-08-18  1:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-18  1:45 NeilBrown [this message]
2023-08-18  1:45 ` [PATCH 1/7] SUNRPC: change service idle list to be an llist NeilBrown
2023-08-18 15:53   ` Chuck Lever
2023-08-30  1:52     ` NeilBrown
2023-08-18  1:45 ` [PATCH 2/7] SUNRPC: only have one thread waking up at a time NeilBrown
2023-08-18  1:45 ` [PATCH 3/7] SUNRPC/svc: add light-weight queuing mechanism NeilBrown
2023-08-18  1:45 ` [PATCH 4/7] SUNRPC: use lwq for sp_sockets - renamed to sp_xprts NeilBrown
2023-08-18  1:45 ` [PATCH 5/7] SUNRPC: change sp_nrthreads to atomic_t NeilBrown
2023-08-18  1:45 ` [PATCH 6/7] SUNRPC: discard sp_lock NeilBrown
2023-08-18  1:45 ` [PATCH 7/7] SUNRPC: change the back-channel queue to lwq NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230818014512.26880-1-neilb@suse.de \
    --to=neilb@suse.de \
    --cc=chuck.lever@oracle.com \
    --cc=jlayton@kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox