From: Jeff Layton <jlayton@kernel.org>
To: fstests@vger.kernel.org
Cc: linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Jeff Layton <jlayton@kernel.org>
Subject: [PATCH fstests v2 3/3] generic/578: only run on filesystems that support FIEMAP
Date: Thu, 24 Aug 2023 12:44:19 -0400 [thread overview]
Message-ID: <20230824-fixes-v2-3-d60c2faf1057@kernel.org> (raw)
In-Reply-To: <20230824-fixes-v2-0-d60c2faf1057@kernel.org>
Some filesystems (e.g. NFS) don't support FIEMAP. Limit generic/578 to
filesystems that do.
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
common/rc | 13 +++++++++++++
tests/generic/578 | 1 +
2 files changed, 14 insertions(+)
diff --git a/common/rc b/common/rc
index 33e74d20c28b..98d27890f6f7 100644
--- a/common/rc
+++ b/common/rc
@@ -3885,6 +3885,19 @@ _require_metadata_journaling()
fi
}
+_require_fiemap()
+{
+ local testfile=$TEST_DIR/fiemaptest.$$
+
+ touch $testfile
+ $XFS_IO_PROG -r -c "fiemap" $testfile 1>$testfile.out 2>&1
+ if grep -q 'Operation not supported' $testfile.out; then
+ _notrun "FIEMAP is not supported by this filesystem"
+ fi
+
+ rm -f $testfile $testfile.out
+}
+
_count_extents()
{
$XFS_IO_PROG -r -c "fiemap" $1 | tail -n +2 | grep -v hole | wc -l
diff --git a/tests/generic/578 b/tests/generic/578
index b024f6ff90b4..903055b2ca58 100755
--- a/tests/generic/578
+++ b/tests/generic/578
@@ -26,6 +26,7 @@ _require_test_program "mmap-write-concurrent"
_require_command "$FILEFRAG_PROG" filefrag
_require_test_reflink
_require_cp_reflink
+_require_fiemap
compare() {
for i in $(seq 1 8); do
--
2.41.0
next prev parent reply other threads:[~2023-08-24 16:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 16:44 [PATCH fstests v2 0/3] fstests: add appropriate checks for fs features for some tests Jeff Layton
2023-08-24 16:44 ` [PATCH fstests v2 1/3] common/attr: fix the _require_acl test Jeff Layton
2023-08-24 16:44 ` [PATCH fstests v2 2/3] generic/513: limit to filesystems that support capabilities Jeff Layton
2023-08-25 14:11 ` Zorro Lang
2023-08-25 15:02 ` Jeff Layton
2023-08-27 12:45 ` Zorro Lang
2023-08-27 13:43 ` Jeff Layton
2023-08-28 14:35 ` Zorro Lang
2023-08-24 16:44 ` Jeff Layton [this message]
2023-08-24 17:09 ` [PATCH fstests v2 3/3] generic/578: only run on filesystems that support FIEMAP Darrick J. Wong
2023-08-24 17:28 ` Jeff Layton
2023-08-25 14:16 ` Zorro Lang
2023-08-25 14:57 ` Jeff Layton
2023-08-25 15:18 ` Darrick J. Wong
2023-08-25 17:34 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230824-fixes-v2-3-d60c2faf1057@kernel.org \
--to=jlayton@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).