Linux NFS development
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: fstests@vger.kernel.org
Cc: linux-nfs@vger.kernel.org, Jeff Layton <jlayton@kernel.org>
Subject: [PATCH fstests 1/3] generic/294: don't run this test on NFS
Date: Thu, 31 Aug 2023 14:40:28 -0400	[thread overview]
Message-ID: <20230831-nfs-skip-v1-1-d54c1c6a9af2@kernel.org> (raw)
In-Reply-To: <20230831-nfs-skip-v1-0-d54c1c6a9af2@kernel.org>

When creating a new dentry (of any type), NFS will optimize away any
on-the-wire lookups prior to the create since that means an extra
round trip to the server. Because of that, it consistently fails this
test.

Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
 tests/generic/294 | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/generic/294 b/tests/generic/294
index 406b1b3954b9..777b62aec9ad 100755
--- a/tests/generic/294
+++ b/tests/generic/294
@@ -15,6 +15,10 @@ _begin_fstest auto quick
 
 # real QA test starts here
 
+# NFS will optimize away the on-the-wire lookup before attempting to
+# create a new file (since that means an extra round trip).
+test $FSTYP = "nfs"  && _notrun "NFS optmizes away lookups on exclusive creates"
+
 # Modify as appropriate.
 _supported_fs generic
 _require_scratch

-- 
2.41.0


  reply	other threads:[~2023-08-31 18:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-31 18:40 [PATCH fstests 0/3] generic: skip a few tests on NFS Jeff Layton
2023-08-31 18:40 ` Jeff Layton [this message]
2023-09-01  5:14   ` [PATCH fstests 1/3] generic/294: don't run this test " Zorro Lang
2023-09-01 10:21     ` Jeff Layton
2023-08-31 18:40 ` [PATCH fstests 2/3] generic/357: " Jeff Layton
2023-08-31 18:40 ` [PATCH fstests 3/3] generic/187: " Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230831-nfs-skip-v1-1-d54c1c6a9af2@kernel.org \
    --to=jlayton@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox