From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA9B9E75455 for ; Tue, 3 Oct 2023 17:55:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240747AbjJCRzu (ORCPT ); Tue, 3 Oct 2023 13:55:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240732AbjJCRzq (ORCPT ); Tue, 3 Oct 2023 13:55:46 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8265CE for ; Tue, 3 Oct 2023 10:55:42 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23721C433C9; Tue, 3 Oct 2023 17:55:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696355742; bh=gcYhbiv6s3HPdYSDDfxpvxQsIE4cXTHj+uXhxeromT0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jq7COVgR1vR7n6LENmxU9AXl21eFb6N6O1Qu/ai9E6q80T8mDYPT6W1xqjYWeOIXr +Ka2yBoLTpYGSjWmTC139YVuXHFkE32ULOBYaQQnSktm1vHHTJNkmV6/aeZL+fwvGj IqJ/x4TXwCh0bfP10r7RD2mC9yZ8ysLm5M4Z9lxcg9mgXWMlxiz7oV70TJGvtiQu9l Iu5w68s8HxuCbaA0TrgfFlbJT+wghD8N8YzkhZnjmTgRyctqJCRS83Lvz1r2bgmsd3 uibAWpQ8lydTM9OZuvFxQwZIkx21R81WElXmWUbYlXPAVUYeBTwhUDQ5ExOQZTTOqu zN5BDUfDQzjEg== Date: Tue, 3 Oct 2023 10:55:40 -0700 From: Jakub Kicinski To: Lorenzo Bianconi Cc: linux-nfs@vger.kernel.org, lorenzo.bianconi@redhat.com, chuck.lever@oracle.com, jlayton@kernel.org, neilb@suse.de, netdev@vger.kernel.org Subject: Re: [PATCH v8 1/3] Documentation: netlink: add a YAML spec for nfsd_server Message-ID: <20231003105540.75a3e652@kernel.org> In-Reply-To: <47c144cfa1859ab089527e67c8540eb920427c64.1694436263.git.lorenzo@kernel.org> References: <47c144cfa1859ab089527e67c8540eb920427c64.1694436263.git.lorenzo@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Mon, 11 Sep 2023 14:49:44 +0200 Lorenzo Bianconi wrote: > Introduce nfsd_server.yaml specs to generate uAPI and netlink > code for nfsd server. > Add rpc-status specs to define message reported by the nfsd server > dumping the pending RPC requests. Sorry for the delay, some minor "take it or leave it" nits below. > +doc: > + nfsd server configuration over generic netlink. > + > +attribute-sets: > + - > + name: rpc-status-comp-op-attr > + enum-name: nfsd-rpc-status-comp-attr > + name-prefix: nfsd-attr-rpc-status-comp- > + attributes: > + - > + name: unspec > + type: unused > + value: 0 the unused attrs can usually be skipped, the specs now start with value of 1 by default. Same for the unused command. > + - > + name: dport > + type: u16 > + byte-order: big-endian > + - > + name: compond-op > + type: array-nest Avoid array-nests if you can, they are legacy (does this spec pass JSON schema validation?). There's only one attribute in the nest, can you use - name: op type: u32 multi-attr: true ? > + nested-attributes: rpc-status-comp-op-attr > + - > + name: rpc-status-get > + doc: dump pending nfsd rpc > + attribute-set: rpc-status-attr > + dump: > + pre: nfsd-server-nl-rpc-status-get-start > + post: nfsd-server-nl-rpc-status-get-done No attributes listed? User space C codegen will need those to make sense of the commands.