Re: [PATCH 1/6] nfsd: prepare for supporting admin-revocation of state

[kernel test robot <lkp@intel.com>]

Hi NeilBrown,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.6 next-20231030]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/NeilBrown/nfsd-prepare-for-supporting-admin-revocation-of-state/20231027-095832
base:   linus/master
patch link:    https://lore.kernel.org/r/20231027015613.26247-2-neilb%40suse.de
patch subject: [PATCH 1/6] nfsd: prepare for supporting admin-revocation of state
config: arm-keystone_defconfig (https://download.01.org/0day-ci/archive/20231031/202310311025.kdFXiVKx-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231031/202310311025.kdFXiVKx-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310311025.kdFXiVKx-lkp@intel.com/

All errors (new ones prefixed by >>):

   arm-linux-gnueabi-ld: fs/nfsd/nfsctl.o: in function `write_unlock_fs':
>> fs/nfsd/nfsctl.c:283:(.text+0xa58): undefined reference to `nfsd4_revoke_states'


vim +283 fs/nfsd/nfsctl.c

   237	
   238	/*
   239	 * write_unlock_fs - Release all locks on a local file system
   240	 *
   241	 * Experimental.
   242	 *
   243	 * Input:
   244	 *			buf:	'\n'-terminated C string containing the
   245	 *				absolute pathname of a local file system
   246	 *			size:	length of C string in @buf
   247	 * Output:
   248	 *	On success:	returns zero if all specified locks were released;
   249	 *			returns one if one or more locks were not released
   250	 *	On error:	return code is negative errno value
   251	 */
   252	static ssize_t write_unlock_fs(struct file *file, char *buf, size_t size)
   253	{
   254		struct path path;
   255		char *fo_path;
   256		int error;
   257	
   258		/* sanity check */
   259		if (size == 0)
   260			return -EINVAL;
   261	
   262		if (buf[size-1] != '\n')
   263			return -EINVAL;
   264	
   265		fo_path = buf;
   266		if (qword_get(&buf, fo_path, size) < 0)
   267			return -EINVAL;
   268		trace_nfsd_ctl_unlock_fs(netns(file), fo_path);
   269		error = kern_path(fo_path, 0, &path);
   270		if (error)
   271			return error;
   272	
   273		/*
   274		 * XXX: Needs better sanity checking.  Otherwise we could end up
   275		 * releasing locks on the wrong file system.
   276		 *
   277		 * For example:
   278		 * 1.  Does the path refer to a directory?
   279		 * 2.  Is that directory a mount point, or
   280		 * 3.  Is that directory the root of an exported file system?
   281		 */
   282		error = nlmsvc_unlock_all_by_sb(path.dentry->d_sb);
 > 283		nfsd4_revoke_states(netns(file), path.dentry->d_sb);
   284	
   285		path_put(&path);
   286		return error;
   287	}
   288	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki