Re: [PATCH v4 11/39] netfs: Implement unbuffered/DIO vs buffered I/O locking

Jeff Layton
2023-12-13T16:30:07Z

On Wed, 2023-12-13 at 11:08 -0500, Jeff Layton wrote:
> On Wed, 2023-12-13 at 15:23 +0000, David Howells wrote:
> > Borrow NFS's direct-vs-buffered I/O locking into netfslib. Similar code is
> > also used in ceph.
> >
> > Modify it to have the correct checker annotations for i_rwsem lock
> > acquisition/release and to return -ERESTARTSYS if waits are interrupted.
> >
>
> This is just adding new infrastructure. It'd be nice to go ahead and
> convert a filesystem to use this at the same time. Ceph would be a good
> candidate. Otherwise, I'm not sure how this shakes out as far as
> cleanliness in the callers.
>

Nevermind...I misunderstood what you were trying to do here. You're not
subsuming this into common code that filesystems will use directly, this
is just using the same scheme when doing I/O using netfs helpers.

Ceph and other filesystems will get converted to this when they are
converted to do all of their I/O via netfs.
--
Jeff Layton <jlayton@kernel.org>