Re: [PATCH v4 00/39] netfs, afs, 9p: Delegate high-level I/O to netfslib

Dominique Martinet
2023-12-15T13:30:16Z

Christian Brauner wrote on Fri, Dec 15, 2023 at 01:03:14PM +0100:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
> branch: vfs.netfs

This doesn't seem to build:
-------
CC [M] fs/netfs/buffered_write.o
fs/netfs/buffered_write.c: In function ‘netfs_kill_pages’:
fs/netfs/buffered_write.c:569:17: error: implicit declaration of function ‘generic_error_remove_folio’; did you mean ‘generic_error_remove_page’? [-Werror=implicit-function-declaration]
569 | generic_error_remove_folio(mapping, folio);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
| generic_error_remove_page
cc1: some warnings being treated as errors
-------

This helper is present in -next as commit af7628d6ec19 ("fs: convert
error_remove_page to error_remove_folio") (as of now's next), apparently
from akpm's mm-stable:
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm mm-stable

(which obviously have some conflict in afs when trying to merge...)

I'll go back to dhowell's tree to finally test 9p a bit,
sorry for lack of involvement just low on time all around.

Good luck (?),
--
Dominique Martinet | Asmadeus