From: Christian Brauner <brauner@kernel.org>
To: Dai Ngo <dai.ngo@oracle.com>
Cc: Jorge.Mora@netapp.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/1] nfstest_posix: add check for EINVAL when open(2) called with O_DIRECTORY|O_CREAT
Date: Thu, 18 Jan 2024 15:39:06 +0100 [thread overview]
Message-ID: <20240118-karierte-dortig-ee53d1a49abc@brauner> (raw)
In-Reply-To: <1705514501-2098-1-git-send-email-dai.ngo@oracle.com>
On Wed, Jan 17, 2024 at 10:01:41AM -0800, Dai Ngo wrote:
> The 'open' tests of nfstest_posix failed with 6.7 kernel with these errors:
>
> FAIL: open - opening existent file should return an error when O_EXCL|O_CREAT is used (256 passed, 256 failed)
> FAIL: open - opening symbolic link should return an error when O_EXCL|O_CREAT is used (256 passed, 256 failed)
>
> These tests failed due to the commit 43b450632676 that fixes problems
> with VFS API:
>
> 43b450632676: open: return EINVAL for O_DIRECTORY | O_CREAT
>
> This patch fixes the problem by adding a check for EINVAL when the
> open(2) was called with O_DIRECTORY | O_CREAT.
>
> Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
> ---
Thank you!
next prev parent reply other threads:[~2024-01-18 14:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 18:01 [PATCH 1/1] nfstest_posix: add check for EINVAL when open(2) called with O_DIRECTORY|O_CREAT Dai Ngo
2024-01-18 14:39 ` Christian Brauner [this message]
2024-02-20 21:25 ` dai.ngo
2024-02-22 16:13 ` Mora, Jorge
2024-02-22 17:45 ` dai.ngo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240118-karierte-dortig-ee53d1a49abc@brauner \
--to=brauner@kernel.org \
--cc=Jorge.Mora@netapp.com \
--cc=dai.ngo@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).