* [PATCH] sunrpc: remove SLAB_MEM_SPREAD flag usage @ 2024-02-24 13:51 chengming.zhou 2024-02-26 4:23 ` Chengming Zhou 0 siblings, 1 reply; 6+ messages in thread From: chengming.zhou @ 2024-02-24 13:51 UTC (permalink / raw) To: trond.myklebust, anna, chuck.lever, jlayton, neilb, kolga Cc: Dai.Ngo, tom, davem, edumazet, kuba, pabeni, linux-nfs, netdev, linux-kernel, linux-mm, vbabka, roman.gushchin, Xiongwei.Song, chengming.zhou, Chengming Zhou From: Chengming Zhou <zhouchengming@bytedance.com> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove its usage so we can delete it from slab. No functional change. Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com> --- net/sunrpc/rpc_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sunrpc/rpc_pipe.c b/net/sunrpc/rpc_pipe.c index dcc2b4f49e77..910a5d850d04 100644 --- a/net/sunrpc/rpc_pipe.c +++ b/net/sunrpc/rpc_pipe.c @@ -1490,7 +1490,7 @@ int register_rpc_pipefs(void) rpc_inode_cachep = kmem_cache_create("rpc_inode_cache", sizeof(struct rpc_inode), 0, (SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT| - SLAB_MEM_SPREAD|SLAB_ACCOUNT), + SLAB_ACCOUNT), init_once); if (!rpc_inode_cachep) return -ENOMEM; -- 2.40.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] sunrpc: remove SLAB_MEM_SPREAD flag usage 2024-02-24 13:51 [PATCH] sunrpc: remove SLAB_MEM_SPREAD flag usage chengming.zhou @ 2024-02-26 4:23 ` Chengming Zhou 2024-02-27 17:13 ` Simon Horman 0 siblings, 1 reply; 6+ messages in thread From: Chengming Zhou @ 2024-02-26 4:23 UTC (permalink / raw) To: trond.myklebust, anna, chuck.lever, jlayton, neilb, kolga Cc: Dai.Ngo, tom, davem, edumazet, kuba, pabeni, linux-nfs, netdev, linux-kernel, vbabka, roman.gushchin, Xiongwei.Song On 2024/2/24 21:51, chengming.zhou@linux.dev wrote: > From: Chengming Zhou <zhouchengming@bytedance.com> > > The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove > its usage so we can delete it from slab. No functional change. Update changelog to make it clearer: The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was removed as of v6.8-rc1, so it became a dead flag since the commit 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the series[1] went on to mark it obsolete to avoid confusion for users. Here we can just remove all its users, which has no functional change. [1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/ Thanks! > > Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com> > --- > net/sunrpc/rpc_pipe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/sunrpc/rpc_pipe.c b/net/sunrpc/rpc_pipe.c > index dcc2b4f49e77..910a5d850d04 100644 > --- a/net/sunrpc/rpc_pipe.c > +++ b/net/sunrpc/rpc_pipe.c > @@ -1490,7 +1490,7 @@ int register_rpc_pipefs(void) > rpc_inode_cachep = kmem_cache_create("rpc_inode_cache", > sizeof(struct rpc_inode), > 0, (SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT| > - SLAB_MEM_SPREAD|SLAB_ACCOUNT), > + SLAB_ACCOUNT), > init_once); > if (!rpc_inode_cachep) > return -ENOMEM; ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] sunrpc: remove SLAB_MEM_SPREAD flag usage 2024-02-26 4:23 ` Chengming Zhou @ 2024-02-27 17:13 ` Simon Horman 2024-02-28 3:00 ` [PATCH v2] " Chengming Zhou 2024-02-28 3:12 ` [PATCH v3] " Chengming Zhou 0 siblings, 2 replies; 6+ messages in thread From: Simon Horman @ 2024-02-27 17:13 UTC (permalink / raw) To: Chengming Zhou Cc: trond.myklebust, anna, chuck.lever, jlayton, neilb, kolga, Dai.Ngo, tom, davem, edumazet, kuba, pabeni, linux-nfs, netdev, linux-kernel, vbabka, roman.gushchin, Xiongwei.Song On Mon, Feb 26, 2024 at 12:23:49PM +0800, Chengming Zhou wrote: > On 2024/2/24 21:51, chengming.zhou@linux.dev wrote: > > From: Chengming Zhou <zhouchengming@bytedance.com> > > > > The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove > > its usage so we can delete it from slab. No functional change. > > Update changelog to make it clearer: > > The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was > removed as of v6.8-rc1, so it became a dead flag since the commit > 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the > series[1] went on to mark it obsolete to avoid confusion for users. > Here we can just remove all its users, which has no functional change. > > [1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/ > > Thanks! Thanks Chengming Zhou, As per my comment on a similar patch [*], this seems reasonable to me. But I think it would be best to post a v2 of this patch with the updated patch description (which is very helpful, BTW). [*] https://lore.kernel.org/all/20240227170937.GD277116@kernel.org/ > > > > > Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com> > > --- > > net/sunrpc/rpc_pipe.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/net/sunrpc/rpc_pipe.c b/net/sunrpc/rpc_pipe.c > > index dcc2b4f49e77..910a5d850d04 100644 > > --- a/net/sunrpc/rpc_pipe.c > > +++ b/net/sunrpc/rpc_pipe.c > > @@ -1490,7 +1490,7 @@ int register_rpc_pipefs(void) > > rpc_inode_cachep = kmem_cache_create("rpc_inode_cache", > > sizeof(struct rpc_inode), > > 0, (SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT| > > - SLAB_MEM_SPREAD|SLAB_ACCOUNT), > > + SLAB_ACCOUNT), > > init_once); Also, while we are here, perhaps the indentation can be improved. Something like: rpc_inode_cachep = kmem_cache_create("rpc_inode_cache", sizeof(struct rpc_inode), 0, (SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT| SLAB_ACCOUNT), init_once); > > if (!rpc_inode_cachep) > > return -ENOMEM; > ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] sunrpc: remove SLAB_MEM_SPREAD flag usage 2024-02-27 17:13 ` Simon Horman @ 2024-02-28 3:00 ` Chengming Zhou 2024-02-28 3:12 ` [PATCH v3] " Chengming Zhou 1 sibling, 0 replies; 6+ messages in thread From: Chengming Zhou @ 2024-02-28 3:00 UTC (permalink / raw) To: horms; +Cc: chuck.lever, jlayton, neilb, kolga, linux-nfs, netdev, Chengming Zhou From: Chengming Zhou <zhouchengming@bytedance.com> The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was removed as of v6.8-rc1, so it became a dead flag since the commit 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the series[1] went on to mark it obsolete to avoid confusion for users. Here we can just remove all its users, which has no functional change. [1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/ Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com> --- v2: - Update the patch description and include the related link to make it clearer that SLAB_MEM_SPREAD flag is now a no-op. --- net/sunrpc/rpc_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sunrpc/rpc_pipe.c b/net/sunrpc/rpc_pipe.c index dcc2b4f49e77..910a5d850d04 100644 --- a/net/sunrpc/rpc_pipe.c +++ b/net/sunrpc/rpc_pipe.c @@ -1490,7 +1490,7 @@ int register_rpc_pipefs(void) rpc_inode_cachep = kmem_cache_create("rpc_inode_cache", sizeof(struct rpc_inode), 0, (SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT| - SLAB_MEM_SPREAD|SLAB_ACCOUNT), + SLAB_ACCOUNT), init_once); if (!rpc_inode_cachep) return -ENOMEM; -- 2.40.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v3] sunrpc: remove SLAB_MEM_SPREAD flag usage 2024-02-27 17:13 ` Simon Horman 2024-02-28 3:00 ` [PATCH v2] " Chengming Zhou @ 2024-02-28 3:12 ` Chengming Zhou 2024-02-28 15:06 ` Simon Horman 1 sibling, 1 reply; 6+ messages in thread From: Chengming Zhou @ 2024-02-28 3:12 UTC (permalink / raw) To: horms; +Cc: chuck.lever, jlayton, neilb, kolga, linux-nfs, netdev, Chengming Zhou From: Chengming Zhou <zhouchengming@bytedance.com> The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was removed as of v6.8-rc1, so it became a dead flag since the commit 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the series[1] went on to mark it obsolete to avoid confusion for users. Here we can just remove all its users, which has no functional change. [1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/ Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com> --- v3: - Improve the indentation, per Simon Horman. v2: - Update the patch description and include the related link to make it clearer that SLAB_MEM_SPREAD flag is now a no-op. --- net/sunrpc/rpc_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sunrpc/rpc_pipe.c b/net/sunrpc/rpc_pipe.c index dcc2b4f49e77..b639d8eb6080 100644 --- a/net/sunrpc/rpc_pipe.c +++ b/net/sunrpc/rpc_pipe.c @@ -1490,7 +1490,7 @@ int register_rpc_pipefs(void) rpc_inode_cachep = kmem_cache_create("rpc_inode_cache", sizeof(struct rpc_inode), 0, (SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT| - SLAB_MEM_SPREAD|SLAB_ACCOUNT), + SLAB_ACCOUNT), init_once); if (!rpc_inode_cachep) return -ENOMEM; -- 2.40.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v3] sunrpc: remove SLAB_MEM_SPREAD flag usage 2024-02-28 3:12 ` [PATCH v3] " Chengming Zhou @ 2024-02-28 15:06 ` Simon Horman 0 siblings, 0 replies; 6+ messages in thread From: Simon Horman @ 2024-02-28 15:06 UTC (permalink / raw) To: Chengming Zhou Cc: chuck.lever, jlayton, neilb, kolga, linux-nfs, netdev, Chengming Zhou On Wed, Feb 28, 2024 at 03:12:34AM +0000, Chengming Zhou wrote: > From: Chengming Zhou <zhouchengming@bytedance.com> > > The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was > removed as of v6.8-rc1, so it became a dead flag since the commit > 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the > series[1] went on to mark it obsolete to avoid confusion for users. > Here we can just remove all its users, which has no functional change. > > [1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/ > > Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com> > --- > v3: > - Improve the indentation, per Simon Horman. > > v2: > - Update the patch description and include the related link to > make it clearer that SLAB_MEM_SPREAD flag is now a no-op. Thanks for the updates. Reviewed-by: Simon Horman <horms@kernel.org> In future please consider the following: 1. Don't post new revisions of a series more than once every 24h 2. Do post new revisions as new email threads Link: https://docs.kernel.org/process/maintainer-netdev.html ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-02-28 15:06 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-02-24 13:51 [PATCH] sunrpc: remove SLAB_MEM_SPREAD flag usage chengming.zhou 2024-02-26 4:23 ` Chengming Zhou 2024-02-27 17:13 ` Simon Horman 2024-02-28 3:00 ` [PATCH v2] " Chengming Zhou 2024-02-28 3:12 ` [PATCH v3] " Chengming Zhou 2024-02-28 15:06 ` Simon Horman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).