* [PATCH] SUNRPC: Remove comment for sp_lock
@ 2024-04-26 3:47 Guoqing Jiang
2024-04-26 4:06 ` NeilBrown
2024-04-26 13:02 ` Chuck Lever
0 siblings, 2 replies; 4+ messages in thread
From: Guoqing Jiang @ 2024-04-26 3:47 UTC (permalink / raw)
To: trond.myklebust, anna, chuck.lever, jlayton, neilb, kolga,
Dai.Ngo, tom
Cc: linux-nfs
It is obsolete since sp_lock was discarded in commit 580a25756a9f
("SUNRPC: discard sp_lock").
Signed-off-by: Guoqing Jiang <guoqing.jiang@linux.dev>
---
net/sunrpc/svc_xprt.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/sunrpc/svc_xprt.c b/net/sunrpc/svc_xprt.c
index b4a85a227bd7..ec78c277a02e 100644
--- a/net/sunrpc/svc_xprt.c
+++ b/net/sunrpc/svc_xprt.c
@@ -46,7 +46,6 @@ static LIST_HEAD(svc_xprt_class_list);
/* SMP locking strategy:
*
- * svc_pool->sp_lock protects most of the fields of that pool.
* svc_serv->sv_lock protects sv_tempsocks, sv_permsocks, sv_tmpcnt.
* when both need to be taken (rare), svc_serv->sv_lock is first.
* The "service mutex" protects svc_serv->sv_nrthread.
--
2.35.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] SUNRPC: Remove comment for sp_lock
2024-04-26 3:47 [PATCH] SUNRPC: Remove comment for sp_lock Guoqing Jiang
@ 2024-04-26 4:06 ` NeilBrown
2024-04-26 6:15 ` Guoqing Jiang
2024-04-26 13:02 ` Chuck Lever
1 sibling, 1 reply; 4+ messages in thread
From: NeilBrown @ 2024-04-26 4:06 UTC (permalink / raw)
To: Guoqing Jiang
Cc: trond.myklebust, anna, chuck.lever, jlayton, kolga, Dai.Ngo, tom,
linux-nfs
On Fri, 26 Apr 2024, Guoqing Jiang wrote:
> It is obsolete since sp_lock was discarded in commit 580a25756a9f
> ("SUNRPC: discard sp_lock").
>
> Signed-off-by: Guoqing Jiang <guoqing.jiang@linux.dev>
> ---
> net/sunrpc/svc_xprt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/sunrpc/svc_xprt.c b/net/sunrpc/svc_xprt.c
> index b4a85a227bd7..ec78c277a02e 100644
> --- a/net/sunrpc/svc_xprt.c
> +++ b/net/sunrpc/svc_xprt.c
> @@ -46,7 +46,6 @@ static LIST_HEAD(svc_xprt_class_list);
>
> /* SMP locking strategy:
> *
> - * svc_pool->sp_lock protects most of the fields of that pool.
> * svc_serv->sv_lock protects sv_tempsocks, sv_permsocks, sv_tmpcnt.
> * when both need to be taken (rare), svc_serv->sv_lock is first.
> * The "service mutex" protects svc_serv->sv_nrthread.
I usually make an effort to find those sorts of things but I obviously
missed it this time.
Thanks.
Reviewed-by: NeilBrown <neilb@suse.de>
NeilBrown
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] SUNRPC: Remove comment for sp_lock
2024-04-26 4:06 ` NeilBrown
@ 2024-04-26 6:15 ` Guoqing Jiang
0 siblings, 0 replies; 4+ messages in thread
From: Guoqing Jiang @ 2024-04-26 6:15 UTC (permalink / raw)
To: NeilBrown
Cc: trond.myklebust, anna, chuck.lever, jlayton, kolga, Dai.Ngo, tom,
linux-nfs
Hi Neil,
On 4/26/24 12:06, NeilBrown wrote:
> On Fri, 26 Apr 2024, Guoqing Jiang wrote:
>> It is obsolete since sp_lock was discarded in commit 580a25756a9f
>> ("SUNRPC: discard sp_lock").
>>
>> Signed-off-by: Guoqing Jiang <guoqing.jiang@linux.dev>
>> ---
>> net/sunrpc/svc_xprt.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/net/sunrpc/svc_xprt.c b/net/sunrpc/svc_xprt.c
>> index b4a85a227bd7..ec78c277a02e 100644
>> --- a/net/sunrpc/svc_xprt.c
>> +++ b/net/sunrpc/svc_xprt.c
>> @@ -46,7 +46,6 @@ static LIST_HEAD(svc_xprt_class_list);
>>
>> /* SMP locking strategy:
>> *
>> - * svc_pool->sp_lock protects most of the fields of that pool.
>> * svc_serv->sv_lock protects sv_tempsocks, sv_permsocks, sv_tmpcnt.
>> * when both need to be taken (rare), svc_serv->sv_lock is first.
>> * The "service mutex" protects svc_serv->sv_nrthread.
>
> I usually make an effort to find those sorts of things but I obviously
> missed it this time.
> Thanks.
I find it occasionally during investigate one nfs issue 😁.
> Reviewed-by: NeilBrown <neilb@suse.de>
Thanks for your review!
Guoqing
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] SUNRPC: Remove comment for sp_lock
2024-04-26 3:47 [PATCH] SUNRPC: Remove comment for sp_lock Guoqing Jiang
2024-04-26 4:06 ` NeilBrown
@ 2024-04-26 13:02 ` Chuck Lever
1 sibling, 0 replies; 4+ messages in thread
From: Chuck Lever @ 2024-04-26 13:02 UTC (permalink / raw)
To: Guoqing Jiang
Cc: trond.myklebust, anna, jlayton, neilb, kolga, Dai.Ngo, tom,
linux-nfs
On Fri, Apr 26, 2024 at 11:47:50AM +0800, Guoqing Jiang wrote:
> It is obsolete since sp_lock was discarded in commit 580a25756a9f
> ("SUNRPC: discard sp_lock").
>
> Signed-off-by: Guoqing Jiang <guoqing.jiang@linux.dev>
> ---
> net/sunrpc/svc_xprt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/sunrpc/svc_xprt.c b/net/sunrpc/svc_xprt.c
> index b4a85a227bd7..ec78c277a02e 100644
> --- a/net/sunrpc/svc_xprt.c
> +++ b/net/sunrpc/svc_xprt.c
> @@ -46,7 +46,6 @@ static LIST_HEAD(svc_xprt_class_list);
>
> /* SMP locking strategy:
> *
> - * svc_pool->sp_lock protects most of the fields of that pool.
> * svc_serv->sv_lock protects sv_tempsocks, sv_permsocks, sv_tmpcnt.
> * when both need to be taken (rare), svc_serv->sv_lock is first.
> * The "service mutex" protects svc_serv->sv_nrthread.
> --
> 2.35.3
>
Applied to nfsd-next (for 6.10). Thank you!
--
Chuck Lever
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-04-26 13:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-26 3:47 [PATCH] SUNRPC: Remove comment for sp_lock Guoqing Jiang
2024-04-26 4:06 ` NeilBrown
2024-04-26 6:15 ` Guoqing Jiang
2024-04-26 13:02 ` Chuck Lever
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).