From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4CCC1CD2B for ; Thu, 20 Jun 2024 04:36:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718858172; cv=none; b=W71FKpT20cNG8MzjRnGAsGOCp/kGRuIFEIlE8xYwC/MQDsbqJF6njTjeEhuuI53jPhEn2ZkBychrtqmm0W4OS4Zk9LkjmN/urLQpKoDedfuqkHbiAMPDzUOCOaNNkhDGa30hCXVVkl2WZweg+iqP7Zzcj0OxlDJBrOv1T1wlMjA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718858172; c=relaxed/simple; bh=SmXob1U4VyMfLPAyDym/T1JOPDSm+dn8NWAvwrbcMos=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jRa7b3imWH2cPJom2JMGO3HPjgFteK2ISNPF4mtuieeeaX2iuSQBXDZslLR6AVaLEMq5l/p6I4sYww1MhIeTOSLJRSgCgEmCkPh/DouUL9plWdABaGsUQxQ/x/1eAyyY0I8Kdh6vZMRn0XfAzYwFOQBCst0Glqqb6DNXtqomwj8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id C7A9B68BEB; Thu, 20 Jun 2024 06:36:05 +0200 (CEST) Date: Thu, 20 Jun 2024 06:36:05 +0200 From: Christoph Hellwig To: cel@kernel.org Cc: linux-nfs@vger.kernel.org, Christoph Hellwig , Chuck Lever Subject: Re: [RFC PATCH 2/4] nfs/blocklayout: Report only when /no/ device is found Message-ID: <20240620043605.GA19613@lst.de> References: <20240619173929.177818-6-cel@kernel.org> <20240619173929.177818-8-cel@kernel.org> Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240619173929.177818-8-cel@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) On Wed, Jun 19, 2024 at 01:39:32PM -0400, cel@kernel.org wrote: > if (IS_ERR(bdev_file)) { > - pr_warn("pNFS: failed to open device %s (%ld)\n", > + dprintk("failed to open device %s (%ld)\n", > devname, PTR_ERR(bdev_file)); I'd just drop this one entirely. Otherwise this looks good: Reviewed-by: Christoph Hellwig