From: Christoph Hellwig <hch@lst.de>
To: cel@kernel.org
Cc: linux-nfs@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Chuck Lever <chuck.lever@oracle.com>
Subject: Re: [RFC PATCH 4/4] nfs/blocklayout: Use bulk page allocation APIs
Date: Thu, 20 Jun 2024 06:44:47 +0200 [thread overview]
Message-ID: <20240620044447.GB19613@lst.de> (raw)
In-Reply-To: <20240619173929.177818-10-cel@kernel.org>
On Wed, Jun 19, 2024 at 01:39:34PM -0400, cel@kernel.org wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
>
> nfs4_get_device_info() frequently requests more than a few pages
> when provisioning a nfs4_deviceid_node object.
Hmm. Looks like nfs4_get_device_info uses max_resp_sz to size
the buffer. In theory the max_deviceinfo_size field in
struct pnfs_layoutdriver_type caps it, but that isn't actually set
anywhere at all.
I guess we can't really do anything to size this better, but at least
for blocklayout where we usually get a single device or a handful
of stripes this is quite an overallocation.
And all that is just to pass it to xdr_init_decode_pages, which
is using it basically as a scratchpad.
prev parent reply other threads:[~2024-06-20 4:44 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 17:39 [RFC PATCH 0/4] Snapshot of fixes for SCSI PR key registration cel
2024-06-19 17:39 ` [RFC PATCH 1/4] nfs/blocklayout: SCSI layout trace points for reservation key reg/unreg cel
2024-06-20 4:50 ` Christoph Hellwig
2024-06-20 4:52 ` Christoph Hellwig
2024-06-20 14:30 ` Chuck Lever
2024-06-19 17:39 ` [RFC PATCH 2/4] nfs/blocklayout: Report only when /no/ device is found cel
2024-06-20 4:36 ` Christoph Hellwig
2024-06-20 14:59 ` Chuck Lever
2024-06-20 12:17 ` Benjamin Coddington
2024-06-20 14:10 ` Christoph Hellwig
2024-06-19 17:39 ` [RFC PATCH 3/4] nfs/blocklayout: Fix premature PR key unregistration cel
2024-06-20 5:06 ` Christoph Hellwig
2024-06-20 13:52 ` Benjamin Coddington
2024-06-20 13:58 ` Chuck Lever
2024-06-20 14:15 ` Christoph Hellwig
2024-06-20 14:18 ` Chuck Lever III
2024-06-20 15:45 ` Benjamin Coddington
2024-06-20 15:48 ` Chuck Lever
2024-06-20 15:58 ` Benjamin Coddington
2024-06-20 15:39 ` Chuck Lever
2024-06-20 13:51 ` Benjamin Coddington
2024-06-20 14:34 ` Chuck Lever
2024-06-20 14:37 ` Christoph Hellwig
2024-06-20 15:30 ` Benjamin Coddington
2024-06-20 15:46 ` Chuck Lever
2024-06-20 15:56 ` Benjamin Coddington
2024-06-20 16:45 ` Benjamin Coddington
2024-06-20 17:08 ` Chuck Lever
2024-06-19 17:39 ` [RFC PATCH 4/4] nfs/blocklayout: Use bulk page allocation APIs cel
2024-06-20 4:44 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240620044447.GB19613@lst.de \
--to=hch@lst.de \
--cc=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox