From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 097A81AB91B
	for <linux-nfs@vger.kernel.org>; Thu, 20 Jun 2024 14:11:06 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1718892669; cv=none; b=IMSjm3Y+icCvGKUsYop+pf0tU488YAcW1Jo0LlWGqwyw433oXw8L2l7kwAYSb7pWExTO/hXWT7nPZfMTNsgzh+nUg4hm1H4P+FiWI3f5hVx+B4/pIzvAo8VGo33/ikLUKpeH6dswPln6WZ/pTFkvaVBzDeaN9Xeo9/XOjlB9ZvQ=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1718892669; c=relaxed/simple;
	bh=1yYMtuoiJ7TYGa5HSmZUcSP9R4txOvYQ1s+KAAlGyVw=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=BAom0FWfSyy/bucjgt/fLPGz4idF4oOk9xyZxHPxAcJzUYJU4xBlh9hwEslT03/wvOAFF2BBL0Lc7r6BCdcxuhJvQcf8+jdUZ5cbH/1l7mz3WLr/64ykjxLMUxUeDMhwwF3yjIHey5PNuMwrlY0s4exvbSboeArSTxWMzpTeIkU=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211
Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de
Received: by verein.lst.de (Postfix, from userid 2407)
	id 0BAD168AFE; Thu, 20 Jun 2024 16:10:53 +0200 (CEST)
Date: Thu, 20 Jun 2024 16:10:52 +0200
From: Christoph Hellwig <hch@lst.de>
To: Benjamin Coddington <bcodding@redhat.com>
Cc: cel@kernel.org, linux-nfs@vger.kernel.org,
	Christoph Hellwig <hch@lst.de>,
	Chuck Lever <chuck.lever@oracle.com>
Subject: Re: [RFC PATCH 2/4] nfs/blocklayout: Report only when /no/ device
 is found
Message-ID: <20240620141052.GA20135@lst.de>
References: <20240619173929.177818-6-cel@kernel.org> <20240619173929.177818-8-cel@kernel.org> <89E1818D-3CCA-48B0-AF12-14B0EBD2C350@redhat.com>
Precedence: bulk
X-Mailing-List: linux-nfs@vger.kernel.org
List-Id: <linux-nfs.vger.kernel.org>
List-Subscribe: <mailto:linux-nfs+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-nfs+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <89E1818D-3CCA-48B0-AF12-14B0EBD2C350@redhat.com>
User-Agent: Mutt/1.5.17 (2007-11-01)

On Thu, Jun 20, 2024 at 08:17:12AM -0400, Benjamin Coddington wrote:
> > -	if (IS_ERR(bdev_file))
> > +	if (IS_ERR(bdev_file)) {
> > +		pr_err("pNFS: no device found for volume %*phN\n",
> 
> pr_warn is more appropriate here because there can be clients mounting that
> that don't have block devices for the filesystem.  That's not necessarily a
> configuration problem.

Yes, agreed.