public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: NeilBrown <neilb@suse.de>
To: Mike Snitzer <snitzer@kernel.org>
Cc: linux-nfs@vger.kernel.org, Jeff Layton <jlayton@kernel.org>,
	Chuck Lever <chuck.lever@oracle.com>,
	Trond Myklebust <trondmy@hammerspace.com>
Subject: Suggested improvements for localio support.
Date: Fri, 21 Jun 2024 14:59:27 +1000	[thread overview]
Message-ID: <20240621050857.20075-1-neilb@suse.de> (raw)

These three patches are intend to be merged into the nfs localio patch series.

The first two should be squashed into existing patches as mentioned in
the commit description.  The first is a stand alone patch which cleans
up some ugliness that the current rpcsvc infrastructure requires.

As mentioned in the first patch, a small rearranged of patches is
required for each individual patch to compile.

I would like to suggest changes to the CONFIG options too - I haven't
provided a patch for that.

There should be just one config option: CONFIG_NFS_LOCALIO.  There is no
point enabling for client without server or server without client as in
either configuration nothing useful can be achieved.  There is also no
gain in enabling only for v3 or v4 and not both (unless I've missed
something...)

Despite Jeff's generally sensible suggestion, I'd like the CONFIG option
to be added earliy so that we can compile-test each individual commit.
If that would mean some intermediate commit might be problematic then I
would rather the localio_enabled module parameter were forced to 'false'
until it was safe to turn it on.

I note that the server uses uuid_t while the client doesn't.  I might
have made that worse...  We should probably be consisent.

I have only tested very lightly - treat as a base for further work more
than as a fully polished solution.

Thanks,
NeilBrown

 [PATCH 1/3] NFS: Simplify Client NFS_LOCALIO_PROGRAM support
 [PATCH 2/3] NFSD: Simplify server NFS_LOCALIO_PROGRAM support
 [PATCH 3/3] SUNRPC: replace program list with program array

             reply	other threads:[~2024-06-21  5:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-21  4:59 NeilBrown [this message]
2024-06-21  4:59 ` [PATCH 1/3] NFS: Simplify Client NFS_LOCALIO_PROGRAM support NeilBrown
2024-06-21  4:59 ` [PATCH 2/3] NFSD: Simplify server " NeilBrown
2024-06-21  4:59 ` [PATCH 3/3] SUNRPC: replace program list with program array NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240621050857.20075-1-neilb@suse.de \
    --to=neilb@suse.de \
    --cc=chuck.lever@oracle.com \
    --cc=jlayton@kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=snitzer@kernel.org \
    --cc=trondmy@hammerspace.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox