public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: cel@kernel.org
Cc: linux-nfs@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	Chuck Lever <chuck.lever@oracle.com>
Subject: Re: [PATCH v3 1/3] nfs/blocklayout: Fix premature PR key unregistration
Date: Wed, 26 Jun 2024 07:19:41 +0200	[thread overview]
Message-ID: <20240626051941.GB21996@lst.de> (raw)
In-Reply-To: <20240625200204.276770-6-cel@kernel.org>

On Tue, Jun 25, 2024 at 04:02:06PM -0400, cel@kernel.org wrote:
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

The first signoff always needs the be the author, i.e. you.
I don't think you really need to credit me for this at all anyway.

The change itself looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

  reply	other threads:[~2024-06-26  5:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-25 20:02 [PATCH v3 0/4] Patches for pNFS SCSI layout PR key registration cel
2024-06-25 20:02 ` [PATCH v3 1/3] nfs/blocklayout: Fix premature PR key unregistration cel
2024-06-26  5:19   ` Christoph Hellwig [this message]
2024-06-26 13:43     ` Chuck Lever III
2024-06-26 14:49   ` Benjamin Coddington
2024-06-26 14:52     ` Chuck Lever
2024-06-25 20:02 ` [PATCH v3 2/3] nfs/blocklayout: Report only when /no/ device is found cel
2024-06-25 20:02 ` [PATCH v3 3/3] nfs/blocklayout: SCSI layout trace points for reservation key reg/unreg cel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240626051941.GB21996@lst.de \
    --to=hch@lst.de \
    --cc=cel@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox