Re: [PATCH] nfs: add 'noalignwrite' option for lock-less 'lost writes' prevention

[Dan Aloni <dan.aloni@vastdata.com>]

On 2024-07-03 22:09:58, Sagi Grimberg wrote:
> 
> 
> On 27/06/2024 13:01, Dan Aloni wrote:
> > There are some applications that write to predefined non-overlapping
> > file offsets from multiple clients and therefore don't need to rely on
> > file locking. However, if these applications want non-aligned offsets
> > and sizes they need to either use locks or risk data corruption, as the
> > NFS client defaults to extending writes to whole pages.
> > 
> > This commit adds a new mount option `noalignwrite`, which allows to turn
> > that off and avoid the need of locking, as long as these applications
> > don't overlap on offsets.
> > 
> > Signed-off-by: Dan Aloni <dan.aloni@vastdata.com>
> 
> The new name seems a better choice.
> I'm also on Christoph's camp that having this behavior be the default makes
> sense given that we have large folios.
> 
> Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
> 
> 
> Trond, Anna,
> What are your thoughts on this?

Pinging. Do we need to do anything further? I can prepare the nfs-utils
patch too.

-- 
Dan Aloni