Linux NFS development
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Anna Schumaker <Anna.Schumaker@Netapp.com>,
	Trond Myklebust <trondmy@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Christoph Hellwig <hch@lst.de>, Kairui Song <kasong@tencent.com>,
	NFS Mailing List <linux-nfs@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: linux-next: manual merge of the nfs-anna tree with the mm-stable tree
Date: Mon, 15 Jul 2024 10:58:36 +1000	[thread overview]
Message-ID: <20240715105836.6d6e6e50@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 1870 bytes --]

Hi all,

Today's linux-next merge of the fs-next tree got conflicts in:

  fs/nfs/nfstrace.h
  fs/nfs/write.c

between commit:

  237d29075ca7 ("nfs: drop usage of folio_file_pos")

from the mm-stable tree and commit:

  64568b27b2d2 ("nfs: pass explicit offset/count to trace events")

from the nfs-anna tree.

I fixed it up (for the nfstrace.h file I just used the latter, and see
below) and can carry the fix as necessary. This is now fixed as far as
linux-next is concerned, but any non trivial conflicts should be mentioned
to your upstream maintainer when your tree is submitted for merging.
You may also want to consider cooperating with the maintainer of the
conflicting tree to minimise any particularly complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc fs/nfs/write.c
index 3573cdc4b28f,680505d664f0..000000000000
--- a/fs/nfs/write.c
+++ b/fs/nfs/write.c
@@@ -279,9 -180,9 +180,9 @@@ static void nfs_grow_file(struct folio 
  	spin_lock(&inode->i_lock);
  	i_size = i_size_read(inode);
  	end_index = ((i_size - 1) >> folio_shift(folio)) << folio_order(folio);
- 	if (i_size > 0 && folio_index(folio) < end_index)
+ 	if (i_size > 0 && folio->index < end_index)
  		goto out;
 -	end = folio_file_pos(folio) + (loff_t)offset + (loff_t)count;
 +	end = folio_pos(folio) + (loff_t)offset + (loff_t)count;
  	if (i_size >= end)
  		goto out;
  	trace_nfs_size_grow(inode, end);
@@@ -2073,8 -2062,8 +2062,8 @@@ int nfs_wb_folio_cancel(struct inode *i
   */
  int nfs_wb_folio(struct inode *inode, struct folio *folio)
  {
 -	loff_t range_start = folio_file_pos(folio);
 +	loff_t range_start = folio_pos(folio);
- 	loff_t range_end = range_start + (loff_t)folio_size(folio) - 1;
+ 	size_t len = folio_size(folio);
  	struct writeback_control wbc = {
  		.sync_mode = WB_SYNC_ALL,
  		.nr_to_write = 0,

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2024-07-15  0:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-15  0:58 Stephen Rothwell [this message]
2024-07-15  1:47 ` linux-next: manual merge of the nfs-anna tree with the mm-stable tree Stephen Rothwell
2024-07-15  4:13   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240715105836.6d6e6e50@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=Anna.Schumaker@Netapp.com \
    --cc=akpm@linux-foundation.org \
    --cc=hch@lst.de \
    --cc=kasong@tencent.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trondmy@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox