From: David Howells <dhowells@redhat.com>
To: Christian Brauner <christian@brauner.io>
Cc: David Howells <dhowells@redhat.com>,
Pankaj Raghav <p.raghav@samsung.com>,
Jeff Layton <jlayton@kernel.org>,
Matthew Wilcox <willy@infradead.org>,
netfs@lists.linux.dev, linux-afs@lists.infradead.org,
linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org,
ceph-devel@vger.kernel.org, v9fs@lists.linux.dev,
linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/5] netfs, cifs: Further fixes
Date: Fri, 23 Aug 2024 17:12:01 +0100 [thread overview]
Message-ID: <20240823161209.434705-1-dhowells@redhat.com> (raw)
Hi Christian, Steve,
Here are some more fixes to cifs and one to netfs:
(1) Fix cifs FALLOC_FL_PUNCH_HOLE support as best I can. If it's going to
punch a hole in dirty data in the pagecacne, invalidating that data
may result in the EOF not being moved correctly. The set-zero and the
eof-move RPC ops really need compounding to avoid third-party
interference.
(2) Adjust three debugging output statements. Not strictly a fix, so
could be dropped. Including the subreq ID in some extra debug lines
helps a bit, though.
(3) Fix netfslib's short read retry to reset the buffer iterator otherwise
the wrong part of the buffer may get written on.
(4) Further fix the early EOF detection in cifs read.
(5) Further fixes for cifs credit handling.
The patches can also be found here:
https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=netfs-fixes
Thanks,
David
David Howells (5):
cifs: Fix FALLOC_FL_PUNCH_HOLE support
netfs, cifs: Improve some debugging bits
netfs: Fix missing iterator reset on retry of short read
cifs: Fix short read handling
cifs: Fix credit handling
fs/netfs/io.c | 3 ++-
fs/smb/client/file.c | 9 +++++++++
fs/smb/client/smb2ops.c | 34 ++++++++++++++++++++++++++++++----
fs/smb/client/smb2pdu.c | 12 ++----------
fs/smb/client/trace.h | 1 +
5 files changed, 44 insertions(+), 15 deletions(-)
next reply other threads:[~2024-08-23 16:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-23 16:12 David Howells [this message]
2024-08-23 16:12 ` [PATCH 1/5] cifs: Fix FALLOC_FL_PUNCH_HOLE support David Howells
2024-08-23 16:12 ` [PATCH 2/5] netfs, cifs: Improve some debugging bits David Howells
2024-08-23 16:12 ` [PATCH 3/5] netfs: Fix missing iterator reset on retry of short read David Howells
2024-08-23 16:12 ` [PATCH 4/5] cifs: Fix short read handling David Howells
2024-08-23 16:12 ` [PATCH 5/5] cifs: Fix credit handling David Howells
2024-08-23 16:19 ` Samba llseek bug David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240823161209.434705-1-dhowells@redhat.com \
--to=dhowells@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=christian@brauner.io \
--cc=jlayton@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=netfs@lists.linux.dev \
--cc=p.raghav@samsung.com \
--cc=v9fs@lists.linux.dev \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).