From: Bugspray Bot <bugbot@kernel.org>
To: trondmy@kernel.org, cel@kernel.org, jlayton@kernel.org,
linux-nfs@vger.kernel.org, anna@kernel.org
Subject: Re: NFSD callback operations block everything when clients are unresponsive
Date: Fri, 13 Sep 2024 20:05:08 +0000 [thread overview]
Message-ID: <20240913-b218735c1-b1334cb7375b@bugzilla.kernel.org> (raw)
In-Reply-To: <20240913-b218735c0-12465843fe68@bugzilla.kernel.org>
cel writes via Kernel.org Bugzilla:
A little code audit:
1 fs/nfsd/nfs4layouts.c 739 static const struct nfsd4_callback_ops nfsd4_cb_layout_ops = {
2 fs/nfsd/nfs4proc.c 1622 static const struct nfsd4_callback_ops nfsd4_cb_offload_ops = {
6 fs/nfsd/nfs4state.c 399 static const struct nfsd4_callback_ops nfsd4_cb_notify_lock_ops = {
7 fs/nfsd/nfs4state.c 3079 static const struct nfsd4_callback_ops nfsd4_cb_recall_any_ops = {
8 fs/nfsd/nfs4state.c 3084 static const struct nfsd4_callback_ops nfsd4_cb_getattr_ops = {
9 fs/nfsd/nfs4state.c 5182 static const struct nfsd4_callback_ops nfsd4_cb_recall_ops = {
We have these five callback operations to deal with.
I think the ->release nfsd4_callback_ops method might be used to schedule retry -- it's invoked by nfsd41_destroy_cb(), which should be able to tell whether a reply has been received.
Now I just need to figure out how to keep a record of needing to resend a callback.
View: https://bugzilla.kernel.org/show_bug.cgi?id=218735#c1
You can reply to this message to join the discussion.
--
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)
next prev parent reply other threads:[~2024-09-13 20:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 20:05 NFSD callback operations block everything when clients are unresponsive Bugspray Bot
2024-09-13 20:05 ` Bugspray Bot [this message]
2024-09-13 20:05 ` Bugspray Bot
2024-09-13 20:05 ` Bugspray Bot
2024-09-13 20:05 ` Bugspray Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240913-b218735c1-b1334cb7375b@bugzilla.kernel.org \
--to=bugbot@kernel.org \
--cc=anna@kernel.org \
--cc=cel@kernel.org \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox