Re: [6.12-rc2 v2 PATCH 0/7] NFS LOCALIO: fixes and various cleanups

Anna Schumaker
2024-10-03T21:17:43Z

Hi Mike,

On 10/3/24 3:34 PM, Mike Snitzer wrote:
> Hi,
>
> The first 3 patches are clear fixes which are needed ASAP (patch 1 is
> the same from v1 of these series, patch 2 and 3 are new fixes).
>
> The other 4 patches are cleanups that are more subjective (relative to
> them being sent for 6.12-rcX), I'd prefer they go upstream now but I
> can carry them until 6.13 if that is how others would like to proceed.

Thanks for the patches! I'm planning to take the 3 bugfixes for now, and I
think we should save the cleanups for 6.13.

Thanks,
Anna

>
> Please note that there are 3 other LOCALIO related fixes that should
> be merged into 6.12-rcX:
>
> filemap: Fix bounds checking in filemap_read()
> https://lore.kernel.org/all/c6f35a86fe9ae6aa33b2fd3983b4023c2f4f9c13.1726250071.git.trond.myklebust@hammerspace.com/T/
> - still needed, Willy or Christian can you please pick this up?
>
> filemap: filemap_read() should check that the offset is positive or zero
> - Christian has staged this in linux-next via fs-next
>
> sunrpc: fix prog selection loop in svc_process_common
> - Anna has acknowledged the need for this fix but it isn't staged yet
>
> Thanks,
> Mike
>
> Mike Snitzer (7):
> nfs_common: fix race in NFS calls to nfsd_file_put_local() and
> nfsd_serv_put()
> nfs_common: fix Kconfig for NFS_COMMON_LOCALIO_SUPPORT
> nfsd/localio: fix nfsd_file tracepoints to handle NULL rqstp
> nfs/localio: remove redundant suid/sgid handling
> nfs/localio: eliminate unnecessary kref in nfs_local_fsync_ctx
> nfs/localio: remove extra indirect nfs_to call to check
> {read,write}_iter
> nfs/localio: eliminate need for nfs_local_fsync_work forward
> declaration
>
> fs/Kconfig | 2 +-
> fs/nfs/localio.c | 96 ++++++++++++++++----------------------
> fs/nfs_common/nfslocalio.c | 5 +-
> fs/nfsd/filecache.c | 2 +-
> fs/nfsd/localio.c | 2 +-
> fs/nfsd/nfssvc.c | 4 +-
> fs/nfsd/trace.h | 6 +--
> include/linux/nfslocalio.h | 15 ++++++
> 8 files changed, 68 insertions(+), 64 deletions(-)
>