Re: [RFC PATCH v1 1/7] fs: Add inode_get_ino() and implement get_ino() for NFS

Mickaël Salaün
2024-10-11T15:31:11Z

On Fri, Oct 11, 2024 at 07:39:33AM -0700, Christoph Hellwig wrote:
> On Fri, Oct 11, 2024 at 03:52:42PM +0200, Mickaël Salaün wrote:
> > > > Yes, but how do you call getattr() without a path?
> > >
> > > You don't because inode numbers are irrelevant without the path.
> >
> > They are for kernel messages and audit logs. Please take a look at the
> > use cases with the other patches.
>
> It still is useless. E.g. btrfs has duplicate inode numbers due to
> subvolumes.

At least it reflects what users see.

>
> If you want a better pretty but not useful value just work on making
> i_ino 64-bits wide, which is long overdue.

That would require too much work for me, and this would be a pain to
backport to all stable kernels.