public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: Calum Mackay <calum.mackay@oracle.com>
Cc: linux-nfs@vger.kernel.org, Jeff Layton <jlayton@kernel.org>
Subject: [PATCH pynfs v2 5/7] nfs4.1: default to minorversion 2
Date: Mon, 14 Oct 2024 16:50:25 -0400	[thread overview]
Message-ID: <20241014-cb_getattr-v2-5-3782e0d7c598@kernel.org> (raw)
In-Reply-To: <20241014-cb_getattr-v2-0-3782e0d7c598@kernel.org>

Minorversion 2 consists of all optional features, so we can safely just
default to that in pynfs's 4.1 NFS4Client.

Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
 nfs4.1/nfs4client.py | 2 +-
 nfs4.1/testserver.py | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/nfs4.1/nfs4client.py b/nfs4.1/nfs4client.py
index 941cf4000a5f0da254cd826a1d41e37f652e7714..f4fabcc11be1328f47d6d738f78586b3e8541296 100644
--- a/nfs4.1/nfs4client.py
+++ b/nfs4.1/nfs4client.py
@@ -27,7 +27,7 @@ op4 = nfs_ops.NFS4ops()
 SHOW_TRAFFIC = 0
 
 class NFS4Client(rpc.Client, rpc.Server):
-    def __init__(self, host=b'localhost', port=2049, minorversion=1, ctrl_proc=16, summary=None, secure=False):
+    def __init__(self, host=b'localhost', port=2049, minorversion=2, ctrl_proc=16, summary=None, secure=False):
         rpc.Client.__init__(self, 100003, 4)
         self.prog = 0x40000000
         self.versions = [1] # List of supported versions of prog
diff --git a/nfs4.1/testserver.py b/nfs4.1/testserver.py
index 085f0072388ad8a4b477073641ae16268532bc6a..0970c64efe34dcec1e5457b7025faf0cb139670c 100755
--- a/nfs4.1/testserver.py
+++ b/nfs4.1/testserver.py
@@ -74,7 +74,7 @@ def scan_options(p):
                  help="Store test results in xml format [%default]")
     p.add_option("--debug_fail", action="store_true", default=False,
                  help="Force some checks to fail")
-    p.add_option("--minorversion", type="int", default=1,
+    p.add_option("--minorversion", type="int", default=2,
                  metavar="MINORVERSION", help="Choose NFSv4 minor version")
 
     g = OptionGroup(p, "Security flavor options",

-- 
2.47.0


  parent reply	other threads:[~2024-10-14 20:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-14 20:50 [PATCH pynfs v2 0/7] pynfs: add CB_GETATTR tests and tests for delegated timestamps Jeff Layton
2024-10-14 20:50 ` [PATCH pynfs v2 1/7] WRT18: have it also check the ctime between writes Jeff Layton
2024-10-14 20:50 ` [PATCH pynfs v2 2/7] DELEG2: fix write delegation test to open the file RW Jeff Layton
2024-10-14 20:50 ` [PATCH pynfs v2 3/7] pynfs: update maintainer info Jeff Layton
2024-10-14 20:50 ` [PATCH pynfs v2 4/7] nfs4.1: add two CB_GETATTR tests Jeff Layton
2024-10-14 20:50 ` Jeff Layton [this message]
2024-10-15 13:43   ` [PATCH pynfs v2 5/7] nfs4.1: default to minorversion 2 Chuck Lever III
2024-10-15 14:23     ` Jeff Layton
2024-10-15 19:20       ` Chuck Lever III
2024-10-14 20:50 ` [PATCH pynfs v2 6/7] nfs4.1: add support for the "delstid" draft Jeff Layton
2024-10-14 20:50 ` [PATCH pynfs v2 7/7] st_deleg: test delegated timestamps in CB_GETATTR Jeff Layton
2024-10-14 21:24 ` [PATCH pynfs v2 0/7] pynfs: add CB_GETATTR tests and tests for delegated timestamps Calum Mackay
2024-10-22 21:56 ` Calum Mackay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241014-cb_getattr-v2-5-3782e0d7c598@kernel.org \
    --to=jlayton@kernel.org \
    --cc=calum.mackay@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox