From: Christoph Hellwig <hch@lst.de>
To: Benjamin Coddington <bcodding@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@kernel.org>,
Mikulas Patocka <mpatocka@redhat.com>,
dm-devel@lists.linux.dev, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] dm: add support for get_unique_id
Date: Wed, 30 Oct 2024 15:08:23 +0100 [thread overview]
Message-ID: <20241030140823.GA29475@lst.de> (raw)
In-Reply-To: <ABD563AE-C7F3-43C2-A698-479C7D5924BF@redhat.com>
On Wed, Oct 30, 2024 at 10:05:03AM -0400, Benjamin Coddington wrote:
> Match each other in a multipath device you mean? No, this will just return
> the first one where get_unique_id returns non-zero. Can they actually be
> different, and if so should we return an error?
That's what I've been wondering. IIRC you can in theory create a
kernel mpath table for any devices you want. multipathd only creates
them when the ids match, but do we want to rely on that? It might be
perfectly fine to say if you break you keep the pieces, but then
I'd expected a comment about it in the comment.
next prev parent reply other threads:[~2024-10-30 14:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 12:57 [PATCH] dm: add support for get_unique_id Benjamin Coddington
2024-10-30 13:52 ` Christoph Hellwig
2024-10-30 14:05 ` Benjamin Coddington
2024-10-30 14:08 ` Christoph Hellwig [this message]
2024-10-30 14:19 ` Benjamin Coddington
2024-10-30 14:24 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241030140823.GA29475@lst.de \
--to=hch@lst.de \
--cc=agk@redhat.com \
--cc=bcodding@redhat.com \
--cc=dm-devel@lists.linux.dev \
--cc=linux-nfs@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox