Re: [PATCH 3/6] nfsd: add session slot count to /proc/fs/nfsd/clients/*/info

NeilBrown
2024-11-19T22:23:07Z

On Wed, 20 Nov 2024, Chuck Lever wrote:
> On Tue, Nov 19, 2024 at 11:41:30AM +1100, NeilBrown wrote:
> > Each client now reports the number of slots allocated in each session.
>
> Can this file also report the target slot count? Ie, is the server
> matching the client's requested slot count, or is it over or under
> by some number?

I could. Would you like to suggest a syntax?
Usually the numbers would be the same except for short transition
periods, so I'm not convinced of the value.

Currently if the target is reduced while the client is idle there can be
a longer delay before the slots are actually freed, but I think 2
lease-renewal SEQUENCE ops would do it. If/when we add use of the
CB_RECALL_SLOT callback the delay should disappear.

>
> Would it be useful for a server tester or administrator to poke a
> target slot count value into this file and watch the machinery
> adjust?

Maybe. By echo 3 > drop_caches does a pretty good job. I don't see
that we need more.

Thanks,
NeilBrown