Re: [PATCH RFC 1/6] pseudofs: add support for export_ops

Jan Kara
2024-12-02T15:59:09Z

On Fri 29-11-24 14:38:00, Christian Brauner wrote:
> From: Erin Shepherd <erin.shepherd@e43.eu>
>
> Pseudo-filesystems might reasonably wish to implement the export ops
> (particularly for name_to_handle_at/open_by_handle_at); plumb this
> through pseudo_fs_context
>
> Reviewed-by: Amir Goldstein <amir73il@gmail.com>
> Signed-off-by: Erin Shepherd <erin.shepherd@e43.eu>
> Link: https://lore.kernel.org/r/20241113-pidfs_fh-v2-1-9a4d28155a37@e43.eu
> Signed-off-by: Christian Brauner <brauner@kernel.org>

OK, feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

Honza

> ---
> fs/libfs.c | 1 +
> include/linux/pseudo_fs.h | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/fs/libfs.c b/fs/libfs.c
> index 748ac59231547c29abcbade3fa025e3b00533d8b..2890a9c4a414b7e2be5c337e238db84743f0a30b 100644
> --- a/fs/libfs.c
> +++ b/fs/libfs.c
> @@ -673,6 +673,7 @@ static int pseudo_fs_fill_super(struct super_block *s, struct fs_context *fc)
> s->s_blocksize_bits = PAGE_SHIFT;
> s->s_magic = ctx->magic;
> s->s_op = ctx->ops ?: &simple_super_operations;
> + s->s_export_op = ctx->eops;
> s->s_xattr = ctx->xattr;
> s->s_time_gran = 1;
> root = new_inode(s);
> diff --git a/include/linux/pseudo_fs.h b/include/linux/pseudo_fs.h
> index 730f77381d55f1816ef14adf7dd2cf1d62bb912c..2503f7625d65e7b1fbe9e64d5abf06cd8f017b5f 100644
> --- a/include/linux/pseudo_fs.h
> +++ b/include/linux/pseudo_fs.h
> @@ -5,6 +5,7 @@
>
> struct pseudo_fs_context {
> const struct super_operations *ops;
> + const struct export_operations *eops;
> const struct xattr_handler * const *xattr;
> const struct dentry_operations *dops;
> unsigned long magic;
>
> --
> 2.45.2
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR