From: Scott Mayhew <smayhew@redhat.com>
To: steved@redhat.com
Cc: linux-nfs@vger.kernel.org
Subject: [nfs-utils PATCH] exports: Fix referrals when --enable-junction=no
Date: Mon, 2 Dec 2024 15:30:46 -0500 [thread overview]
Message-ID: <20241202203046.1436990-1-smayhew@redhat.com> (raw)
In-Reply-To: <328fdce3-a66b-4254-a178-389caf75a685@redhat.com>
Commit 15dc0bea ("exportd: Moved cache upcalls routines into
libexport.a") caused write_fsloc() to be elided when junction support is
disabled. Get rid of the bogus #ifdef HAVE_JUNCTION_SUPPORT blocks so
that referrals work again (the only #ifdef HAVE_JUNCTION_SUPPORT should
be around actual junction code).
Fixes: 15dc0bea ("exportd: Moved cache upcalls routines into libexport.a")
Signed-off-by: Scott Mayhew <smayhew@redhat.com>
---
support/export/cache.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/support/export/cache.c b/support/export/cache.c
index 6c0a44a3..3a8e57cf 100644
--- a/support/export/cache.c
+++ b/support/export/cache.c
@@ -34,10 +34,7 @@
#include "pseudoflavors.h"
#include "xcommon.h"
#include "reexport.h"
-
-#ifdef HAVE_JUNCTION_SUPPORT
#include "fsloc.h"
-#endif
#ifdef USE_BLKID
#include "blkid/blkid.h"
@@ -999,7 +996,6 @@ static void nfsd_retry_fh(struct delayed *d)
*dp = d;
}
-#ifdef HAVE_JUNCTION_SUPPORT
static void write_fsloc(char **bp, int *blen, struct exportent *ep)
{
struct servers *servers;
@@ -1022,7 +1018,6 @@ static void write_fsloc(char **bp, int *blen, struct exportent *ep)
qword_addint(bp, blen, servers->h_referral);
release_replicas(servers);
}
-#endif
static void write_secinfo(char **bp, int *blen, struct exportent *ep, int flag_mask, int extra_flag)
{
@@ -1120,9 +1115,7 @@ static int dump_to_cache(int f, char *buf, int blen, char *domain,
qword_addint(&bp, &blen, exp->e_anongid);
qword_addint(&bp, &blen, fsidnum);
-#ifdef HAVE_JUNCTION_SUPPORT
write_fsloc(&bp, &blen, exp);
-#endif
write_secinfo(&bp, &blen, exp, flag_mask, do_fsidnum ? NFSEXP_FSID : 0);
if (exp->e_uuid == NULL || different_fs) {
char u[16];
--
2.46.2
next prev parent reply other threads:[~2024-12-02 20:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-03 16:58 NFSv4 referrals broken when not enabling junction support Salvatore Bonaccorso
2024-10-08 10:12 ` Steve Dickson
2024-10-20 14:37 ` Salvatore Bonaccorso
2024-10-25 20:14 ` Salvatore Bonaccorso
2024-10-26 13:04 ` Steve Dickson
2024-10-26 15:56 ` Salvatore Bonaccorso
2024-11-26 4:57 ` Salvatore Bonaccorso
2024-12-02 18:26 ` Steve Dickson
2024-12-02 19:46 ` Salvatore Bonaccorso
2024-12-02 19:57 ` Steve Dickson
2024-12-02 20:02 ` Chuck Lever III
2024-12-03 12:04 ` Steve Dickson
2024-12-02 20:22 ` Salvatore Bonaccorso
2024-12-02 20:30 ` Scott Mayhew [this message]
2024-12-02 21:25 ` [nfs-utils PATCH] exports: Fix referrals when --enable-junction=no Roland Mainz
2024-12-02 21:41 ` Chuck Lever
2024-12-03 12:11 ` Steve Dickson
2024-12-03 3:19 ` Steve Dickson
2024-12-03 12:43 ` Scott Mayhew
2024-12-03 14:25 ` Steve Dickson
2024-12-03 14:28 ` Chuck Lever III
2024-12-03 16:02 ` Steve Dickson
2024-12-03 16:12 ` Chuck Lever III
2024-12-09 10:26 ` Steve Dickson
2024-12-02 20:00 ` NFSv4 referrals broken when not enabling junction support Chuck Lever III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241202203046.1436990-1-smayhew@redhat.com \
--to=smayhew@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox