From: cel@kernel.org
To: Neil Brown <neilb@suse.de>, Jeff Layton <jlayton@kernel.org>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <dai.ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Cc: <linux-nfs@vger.kernel.org>,
Rick Macklem <rick.macklem@gmail.com>,
Chuck Lever <chuck.lever@oracle.com>
Subject: [PATCH v2 0/2] Fix XDR encoding near page boundaries
Date: Mon, 23 Dec 2024 13:07:25 -0500 [thread overview]
Message-ID: <20241223180724.1804-4-cel@kernel.org> (raw)
From: Chuck Lever <chuck.lever@oracle.com>
Build out the patch series to address the longstanding bug pointed
out by J David and Rick Macklem.
At least during NFSv4 COMPOUND encoding, using
write_bytes_to_xdr_buf() seems less brittle than saving a pointer
into the XDR encoding buffer.
I have one more patch to add (not yet included) that addresses the
issue in the NFSv4 READ and READ_PLUS encoders.
Changes since RFC:
- Document the guarantees around pointer returned by xdr_reserve_space()
- Use write_bytes_to_xdr_buf() instead
Chuck Lever (2):
NFSD: Encode COMPOUND operation status on page boundaries
SUNRPC: Document validity guarantees of the pointer returned by
reserve_space
fs/nfsd/nfs4xdr.c | 20 ++++++++++----------
net/sunrpc/xdr.c | 3 +++
2 files changed, 13 insertions(+), 10 deletions(-)
--
2.47.0
next reply other threads:[~2024-12-23 18:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-23 18:07 cel [this message]
2024-12-23 18:07 ` [PATCH v2 1/2] NFSD: Encode COMPOUND operation status on page boundaries cel
2024-12-23 23:46 ` Rick Macklem
2024-12-24 23:19 ` NeilBrown
2024-12-25 15:53 ` Chuck Lever
2024-12-23 18:07 ` [PATCH v2 2/2] SUNRPC: Document validity guarantees of the pointer returned by reserve_space cel
2024-12-23 23:22 ` [PATCH v2 0/2] Fix XDR encoding near page boundaries Rick Macklem
2024-12-24 14:16 ` Chuck Lever
2024-12-24 15:50 ` Rick Macklem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241223180724.1804-4-cel@kernel.org \
--to=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=dai.ngo@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=okorniev@redhat.com \
--cc=rick.macklem@gmail.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox