Re: [PATCH v2 08/20] afs_d_revalidate(): use stable name and parent inode passed by caller

David Howells
2025-01-22T20:27:55Z

Al Viro <viro@zeniv.linux.org.uk> wrote:

> - _enter("{%lu},%p{%pd},", dir->i_ino, dentry, dentry);
> + _enter("{%lu},{%s},", dir->i_ino, name->name);

I don't think that name->name is guaranteed to be NUL-terminated after
name->len characters. The following:

_enter("{%lu},{%*s},", dir->i_ino, name->len, name->name);

might be better, though:

_enter("{%lu},{%*.*s},", dir->i_ino, name->len, name->len, name->name);

might be necessary.

Apart from that:

Acked-by: David Howells <dhowells@redhat.com>