Re: [PATCH 04/20] dissolve external_name.u into separate members

David Howells
2025-01-10T07:34:23Z

Al Viro <viro@zeniv.linux.org.uk> wrote:

> struct external_name {
> - struct {
> - atomic_t count; // ->count and ->head can't be combined
> - struct rcu_head head; // see take_dentry_name_snapshot()
> - } u;
> + atomic_t count; // ->count and ->head can't be combined
> + struct rcu_head head; // see take_dentry_name_snapshot()
> unsigned char name[];
> };

This gets you a 4-byte hole between count and head on a 64-bit system. Did
you want to flip the order of count and head?

David