From: Scott Mayhew <smayhew@redhat.com>
To: steved@redhat.com
Cc: jlayton@kernel.org, yoyang@redhat.com, linux-nfs@vger.kernel.org
Subject: [nfs-utils PATCH v3 0/3] version handling fixes for nfsdctl and rpc.nfsd
Date: Mon, 13 Jan 2025 18:13:16 -0500 [thread overview]
Message-ID: <20250113231319.951885-1-smayhew@redhat.com> (raw)
Two changes in how nfsdctl does version handling and one for rpc.nfsd.
The first patch makes the 'nfsdctl version' command behave according to
the man page for w.r.t handling +4/-4, e.g.
# utils/nfsdctl/nfsdctl
nfsdctl> threads 0
nfsdctl> version
+3.0 +4.0 +4.1 +4.2
nfsdctl> version -4
nfsdctl> version
+3.0 -4.0 -4.1 -4.2
nfsdctl> version +4
nfsdctl> version
+3.0 +4.0 +4.1 +4.2
nfsdctl> version -4 +4.2
nfsdctl> version
+3.0 -4.0 -4.1 +4.2
nfsdctl> ^D
The second patch makes nfsdctl's handling of the nfsd version options in
nfs.conf behave like rpc.nfsd's. This is important since the systemd
service file will fall back to rpc.nfsd if nfsdctl fails. Note that the
v3 version of this patch also makes 'nfsdctl autostart' fail with an
error if no versions and no minor versions are enabled in nfs.conf.
The third patch (also new in this v3 posting) makes rpc.nfsd consider
the 'minorvers' bit field when determining whether any versions have
been enabled. This takes care of two scenarios:
1) When vers4=y but vers4.0=vers4.1=vers4.2=n
2) When vers2=vers3=vers4=n but any of vers4.0/vers4.1/vers4.2=y
-Scott
Scott Mayhew (3):
nfsdctl: tweak the version subcommand behavior
nfsdctl: tweak the nfs.conf version handling
nfsd: fix version sanity check
utils/nfsd/nfsd.c | 29 +++++++++++---
utils/nfsdctl/nfsdctl.c | 86 +++++++++++++++++++++++++++++++++++------
2 files changed, 98 insertions(+), 17 deletions(-)
--
2.45.2
next reply other threads:[~2025-01-13 23:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 23:13 Scott Mayhew [this message]
2025-01-13 23:13 ` [nfs-utils PATCH v3 1/3] nfsdctl: tweak the version subcommand behavior Scott Mayhew
2025-01-13 23:13 ` [nfs-utils PATCH v3 2/3] nfsdctl: tweak the nfs.conf version handling Scott Mayhew
2025-01-13 23:13 ` [nfs-utils PATCH v3 3/3] nfsd: fix version sanity check Scott Mayhew
2025-01-13 23:20 ` [nfs-utils PATCH v3 0/3] version handling fixes for nfsdctl and rpc.nfsd Scott Mayhew
2025-01-18 12:12 ` Steve Dickson
2025-01-18 12:08 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250113231319.951885-1-smayhew@redhat.com \
--to=smayhew@redhat.com \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=steved@redhat.com \
--cc=yoyang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox