From: Anna Schumaker <anna@kernel.org>
To: linux-nfs@vger.kernel.org, steved@redhat.com
Cc: anna@kernel.org
Subject: [PATCH nfs-utils v2 8/8] rpcctl: Add remaining missing docstrings
Date: Wed, 15 Jan 2025 15:20:35 -0500 [thread overview]
Message-ID: <20250115202035.112122-9-anna@kernel.org> (raw)
In-Reply-To: <20250115202035.112122-1-anna@kernel.org>
From: Anna Schumaker <anna.schumaker@oracle.com>
Signed-off-by: Anna Schumaker <anna.schumaker@oracle.com>
---
tools/rpcctl/rpcctl.py | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/tools/rpcctl/rpcctl.py b/tools/rpcctl/rpcctl.py
index adeb26d51f0e..0221fbb68be1 100755
--- a/tools/rpcctl/rpcctl.py
+++ b/tools/rpcctl/rpcctl.py
@@ -1,4 +1,5 @@
#!/usr/bin/python3
+"""Utility for working with the sunrpc sysfs files."""
import argparse
import collections
import errno
@@ -20,6 +21,7 @@ if not sunrpc.is_dir():
def read_addr_file(path):
+ """Read an xprt address file."""
try:
with open(path, 'r') as f:
return f.readline().strip()
@@ -28,12 +30,14 @@ def read_addr_file(path):
def write_addr_file(path, newaddr):
+ """Write a new address to an xprt address file."""
with open(path, 'w') as f:
f.write(newaddr)
return read_addr_file(path)
def read_info_file(path):
+ """Read an xprt or xprt switch information file."""
res = collections.defaultdict(int)
try:
with open(path) as info:
@@ -246,18 +250,24 @@ class XprtSwitch:
class RpcClient:
+ """Represents an rpc client instance."""
+
def __init__(self, path):
+ """Read in rpc client information from sysfs."""
self.path = path
self.name = path.stem
self.switch = XprtSwitch(path / (path / "switch").readlink(), sep=",")
def __lt__(self, rhs):
+ """Compare the name of two rpc client instances."""
return self.name < rhs.name
def __str__(self):
+ """Return a string representation of an rpc client."""
return f"{self.name}: {self.switch}"
def add_command(subparser):
+ """Add parser options for the `rpcctl client` command."""
parser = subparser.add_parser("client",
help="Commands for rpc clients")
parser.set_defaults(func=RpcClient.show, client=None)
@@ -269,12 +279,14 @@ class RpcClient:
parser.set_defaults(func=RpcClient.show)
def get_by_name(name):
+ """Find a (sorted) list of RpcClients matching the given name."""
rpc_clients = sunrpc / "rpc-clients"
if name:
return [RpcClient(rpc_clients / name)]
return [RpcClient(f) for f in sorted(rpc_clients.iterdir())]
def show(args):
+ """Handle the `rpcctl client show` command."""
for client in RpcClient.get_by_name(args.client):
print(client)
@@ -283,6 +295,7 @@ parser = argparse.ArgumentParser()
def show_small_help(args):
+ """Show a one-line usage summary if no subcommand is given."""
parser.print_usage()
print("sunrpc dir:", sunrpc)
--
2.48.1
prev parent reply other threads:[~2025-01-15 20:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 20:20 [PATCH nfs-utils v2 0/8] rpcctl: Flake8 cleanups Anna Schumaker
2025-01-15 20:20 ` [PATCH nfs-utils v2 1/8] Patch for broken libnfsimapd static and regex plugins Anna Schumaker
2025-01-15 20:20 ` [PATCH nfs-utils v2 2/8] rpcctl: Fix flake8 whitespace errors Anna Schumaker
2025-01-15 20:20 ` [PATCH nfs-utils v2 3/8] rpcctl: Fix flake8 line-too-long errors Anna Schumaker
2025-01-15 20:20 ` [PATCH nfs-utils v2 4/8] rpcctl: Fix flake8 bare exception error Anna Schumaker
2025-01-15 20:20 ` [PATCH nfs-utils v2 5/8] rpcctl: Fix flake8 ambiguous-variable-name error Anna Schumaker
2025-01-15 20:20 ` [PATCH nfs-utils v2 6/8] rpcctl: Add missing docstrings to the Xprt class Anna Schumaker
2025-01-15 20:20 ` [PATCH nfs-utils v2 7/8] rpcctl: Add missing docstrings to the XprtSwitch class Anna Schumaker
2025-01-15 20:20 ` Anna Schumaker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250115202035.112122-9-anna@kernel.org \
--to=anna@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox