From: Anna Schumaker <anna@kernel.org>
To: linux-nfs@vger.kernel.org, steved@redhat.com
Cc: anna@kernel.org
Subject: [PATCH nfs-utils v3 2/7] rpcctl: Fix flake8 line-too-long errors
Date: Wed, 15 Jan 2025 15:29:51 -0500 [thread overview]
Message-ID: <20250115202957.113352-3-anna@kernel.org> (raw)
In-Reply-To: <20250115202957.113352-1-anna@kernel.org>
From: Anna Schumaker <anna.schumaker@oracle.com>
Signed-off-by: Anna Schumaker <anna.schumaker@oracle.com>
---
tools/rpcctl/rpcctl.py | 33 ++++++++++++++++++++++-----------
1 file changed, 22 insertions(+), 11 deletions(-)
diff --git a/tools/rpcctl/rpcctl.py b/tools/rpcctl/rpcctl.py
index 92a851c2278b..ec43d12afc41 100755
--- a/tools/rpcctl/rpcctl.py
+++ b/tools/rpcctl/rpcctl.py
@@ -66,13 +66,17 @@ class Xprt:
f"Requests: {self.info['num_reqs']}"
def _cong_slots(self):
- return f" Congestion: cur {self.info['cur_cong']}, win {self.info['cong_win']}, " \
- f"Slots: min {self.info['min_num_slots']}, max {self.info['max_num_slots']}"
+ return f" Congestion: cur {self.info['cur_cong']}, " \
+ f"win {self.info['cong_win']}, " \
+ f"Slots: min {self.info['min_num_slots']}, " \
+ f"max {self.info['max_num_slots']}"
def _queues(self):
return f" Queues: binding {self.info['binding_q_len']}, " \
- f"sending {self.info['sending_q_len']}, pending {self.info['pending_q_len']}, " \
- f"backlog {self.info['backlog_q_len']}, tasks {self.info['tasks_queuelen']}"
+ f"sending {self.info['sending_q_len']}, " \
+ f"pending {self.info['pending_q_len']}, " \
+ f"backlog {self.info['backlog_q_len']}, " \
+ f"tasks {self.info['tasks_queuelen']}"
def __str__(self):
if not self.path.exists():
@@ -106,7 +110,8 @@ class Xprt:
self.set_state("remove")
def add_command(subparser):
- parser = subparser.add_parser("xprt", help="Commands for individual xprts")
+ parser = subparser.add_parser("xprt",
+ help="Commands for individual xprts")
parser.set_defaults(func=Xprt.show, xprt=None)
subparser = parser.add_subparsers()
@@ -128,7 +133,8 @@ class Xprt:
online.set_defaults(func=Xprt.set_property, property="online")
offline = subparser.add_parser("offline", help="Set an xprt offline")
offline.set_defaults(func=Xprt.set_property, property="offline")
- dstaddr = subparser.add_parser("dstaddr", help="Change an xprt's dstaddr")
+ dstaddr = subparser.add_parser("dstaddr",
+ help="Change an xprt's dstaddr")
dstaddr.add_argument("newaddr", metavar="NEWADDR", nargs=1,
help="The new address for the xprt")
dstaddr.set_defaults(func=Xprt.set_property, property="dstaddr")
@@ -161,7 +167,8 @@ class XprtSwitch:
self.path = path
self.name = path.stem
self.info = read_info_file(path / "xprt_switch_info")
- self.xprts = sorted([Xprt(p) for p in self.path.iterdir() if p.is_dir()])
+ self.xprts = sorted([Xprt(p) for p in self.path.iterdir()
+ if p.is_dir()])
self.sep = sep
def __lt__(self, rhs):
@@ -176,7 +183,8 @@ class XprtSwitch:
return "\n".join([switch] + xprts)
def add_command(subparser):
- parser = subparser.add_parser("switch", help="Commands for xprt switches")
+ parser = subparser.add_parser("switch",
+ help="Commands for xprt switches")
parser.set_defaults(func=XprtSwitch.show, switch=None)
subparser = parser.add_subparsers()
@@ -185,11 +193,13 @@ class XprtSwitch:
help="Name of a specific switch to show")
show.set_defaults(func=XprtSwitch.show)
- set = subparser.add_parser("set", help="Change an xprt switch property")
+ set = subparser.add_parser("set",
+ help="Change an xprt switch property")
set.add_argument("switch", metavar="SWITCH", nargs=1,
help="Name of a specific xprt switch to modify")
subparser = set.add_subparsers(required=True)
- dstaddr = subparser.add_parser("dstaddr", help="Change an xprt switch's dstaddr")
+ dstaddr = subparser.add_parser("dstaddr",
+ help="Change an xprt switch's dstaddr")
dstaddr.add_argument("newaddr", metavar="NEWADDR", nargs=1,
help="The new address for the xprt switch")
dstaddr.set_defaults(func=XprtSwitch.set_property, property="dstaddr")
@@ -225,7 +235,8 @@ class RpcClient:
return f"{self.name}: {self.switch}"
def add_command(subparser):
- parser = subparser.add_parser("client", help="Commands for rpc clients")
+ parser = subparser.add_parser("client",
+ help="Commands for rpc clients")
parser.set_defaults(func=RpcClient.show, client=None)
subparser = parser.add_subparsers()
--
2.48.1
next prev parent reply other threads:[~2025-01-15 20:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 20:29 [PATCH nfs-utils v3 0/7] rpcctl: Flake8 cleanups Anna Schumaker
2025-01-15 20:29 ` [PATCH nfs-utils v3 1/7] rpcctl: Fix flake8 whitespace errors Anna Schumaker
2025-01-15 20:29 ` Anna Schumaker [this message]
2025-01-15 20:29 ` [PATCH nfs-utils v3 3/7] rpcctl: Fix flake8 bare exception error Anna Schumaker
2025-01-15 20:29 ` [PATCH nfs-utils v3 4/7] rpcctl: Fix flake8 ambiguous-variable-name error Anna Schumaker
2025-01-15 20:29 ` [PATCH nfs-utils v3 5/7] rpcctl: Add missing docstrings to the Xprt class Anna Schumaker
2025-01-15 20:29 ` [PATCH nfs-utils v3 6/7] rpcctl: Add missing docstrings to the XprtSwitch class Anna Schumaker
2025-01-15 20:29 ` [PATCH nfs-utils v3 7/7] rpcctl: Add remaining missing docstrings Anna Schumaker
2025-01-25 16:33 ` [PATCH nfs-utils v3 0/7] rpcctl: Flake8 cleanups Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250115202957.113352-3-anna@kernel.org \
--to=anna@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox