Re: [PATCH 1/4] nfsd: filecache: use nfsd_file_dispose_list() in nfsd_file_close_inode_sync()

Jeff Layton
2025-01-22T18:58:24Z

On Wed, 2025-01-22 at 14:54 +1100, NeilBrown wrote:
> nfsd_file_close_inode_sync() contains an exactly copy of
> nfsd_file_dispose_list().
>
> This patch removes it and calls nfsd_file_dispose_list() instead.
>
> Signed-off-by: NeilBrown <neilb@suse.de>
> ---
> fs/nfsd/filecache.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c
> index fcd751cb7c76..d8f98e847dc0 100644
> --- a/fs/nfsd/filecache.c
> +++ b/fs/nfsd/filecache.c
> @@ -682,17 +682,12 @@ nfsd_file_close_inode(struct inode *inode)
> void
> nfsd_file_close_inode_sync(struct inode *inode)
> {
> - struct nfsd_file *nf;
> LIST_HEAD(dispose);
>
> trace_nfsd_file_close(inode);
>
> nfsd_file_queue_for_close(inode, &dispose);
> - while (!list_empty(&dispose)) {
> - nf = list_first_entry(&dispose, struct nfsd_file, nf_gc);
> - list_del_init(&nf->nf_gc);
> - nfsd_file_free(nf);
> - }
> + nfsd_file_dispose_list(&dispose);
> }
>
> static int

Reviewed-by: Jeff Layton <jlayton@kernel.org>