Re: [PATCH 1/3] llist: add ability to remove a particular entry from the list

[kernel test robot <lkp@intel.com>]

Hi Olga,

kernel test robot noticed the following build errors:

[auto build test ERROR on trondmy-nfs/linux-next]
[also build test ERROR on brauner-vfs/vfs.all linus/master v6.13 next-20250123]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Olga-Kornievskaia/llist-add-ability-to-remove-a-particular-entry-from-the-list/20250116-072951
base:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
patch link:    https://lore.kernel.org/r/20250115232406.44815-2-okorniev%40redhat.com
patch subject: [PATCH 1/3] llist: add ability to remove a particular entry from the list
config: riscv-allmodconfig (https://download.01.org/0day-ci/archive/20250124/202501240848.ZH81rjTD-lkp@intel.com/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 19306351a2c45e266fa11b41eb1362b20b6ca56d)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250124/202501240848.ZH81rjTD-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501240848.ZH81rjTD-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from lib/test_bitops.c:10:
   In file included from include/linux/module.h:17:
   In file included from include/linux/kmod.h:9:
   In file included from include/linux/umh.h:4:
   In file included from include/linux/gfp.h:7:
   In file included from include/linux/mmzone.h:8:
   In file included from include/linux/spinlock.h:63:
   In file included from include/linux/lockdep.h:14:
   In file included from include/linux/smp.h:15:
   In file included from include/linux/smp_types.h:5:
>> include/linux/llist.h:283:7: error: variable 'pos' is uninitialized when used here [-Werror,-Wuninitialized]
     283 |                 if (pos->next == entry) {
         |                     ^~~
   include/linux/llist.h:269:24: note: initialize the variable 'pos' to silence this warning
     269 |         struct llist_node *pos;
         |                               ^
         |                                = NULL
   1 error generated.


vim +/pos +283 include/linux/llist.h

   255	
   256	/**
   257	 * llist_del_entry - remove a particular entry from a lock-less list
   258	 * @head: head of the list to remove the entry from
   259	 * @entry: entry to be removed from the list
   260	 *
   261	 * Walk the list, find the given entry and remove it from the list.
   262	 * The caller must ensure that nothing can race in and change the
   263	 * list while this is running.
   264	 *
   265	 * Returns true if the entry was found and removed.
   266	 */
   267	static inline bool llist_del_entry(struct llist_head *head, struct llist_node *entry)
   268	{
   269		struct llist_node *pos;
   270	
   271		if (!head->first)
   272			return false;
   273	
   274		/* Is it the first entry? */
   275		if (head->first == entry) {
   276			head->first = entry->next;
   277			entry->next = entry;
   278			return true;
   279		}
   280	
   281		/* Find it in the list */
   282		llist_for_each(head->first, pos) {
 > 283			if (pos->next == entry) {
   284				pos->next = entry->next;
   285				entry->next = entry;
   286				return true;
   287			}
   288		}
   289		return false;
   290	}
   291	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki