From: NeilBrown <neilb@suse.de>
To: Chuck Lever <chuck.lever@oracle.com>, Jeff Layton <jlayton@kernel.org>
Cc: linux-nfs@vger.kernel.org,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
Dave Chinner <david@fromorbit.com>
Subject: [PATCH 0/7] nfsd: filecache: change garbage collection lists
Date: Mon, 27 Jan 2025 12:20:31 +1100 [thread overview]
Message-ID: <20250127012257.1803314-1-neilb@suse.de> (raw)
[
davec added to cc incase I've said something incorrect about list_lru
Changes in this version:
- no _bh locking
- add name for a magic constant
- remove unnecessary race-handling code
- give a more meaningfule name for a lock for /proc/lock_stat
- minor cleanups suggested by Jeff
]
The nfsd filecache currently uses list_lru for tracking files recently
used in NFSv3 requests which need to be "garbage collected" when they
have becoming idle - unused for 2-4 seconds.
I do not believe list_lru is a good tool for this. It does not allow
the timeout which filecache requires so we have to add a timeout
mechanism which holds the list_lru lock while the whole list is scanned
looking for entries that haven't been recently accessed. When the list
is largish (even a few hundred) this can block new requests noticably
which need the lock to remove a file to access it.
This patch removes the list_lru and instead uses 2 simple linked lists.
When a file is accessed it is removed from whichever list it is on,
then added to the tail of the first list. Every 2 seconds the second
list is moved to the "freeme" list and the first list is moved to the
second list. This avoids any need to walk a list to find old entries.
These lists are per-netns rather than global as the freeme list is
per-netns as the actual freeing is done in nfsd threads which are
per-netns.
Thanks,
NeilBrown
[PATCH 1/7] nfsd: filecache: remove race handling.
[PATCH 2/7] nfsd: filecache: use nfsd_file_dispose_list() in
[PATCH 3/7] nfsd: filecache: move globals nfsd_file_lru and
[PATCH 4/7] nfsd: filecache: change garbage collection list
[PATCH 5/7] nfsd: filecache: document the arbitrary limit on
[PATCH 6/7] nfsd: filecache: change garbage collection to a timer.
[PATCH 7/7] nfsd: filecache: give disposal lock a unique class name.
next reply other threads:[~2025-01-27 1:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-27 1:20 NeilBrown [this message]
2025-01-27 1:20 ` [PATCH 1/7] nfsd: filecache: remove race handling NeilBrown
2025-01-27 13:42 ` Jeff Layton
2025-01-27 1:20 ` [PATCH 2/7] nfsd: filecache: use nfsd_file_dispose_list() in nfsd_file_close_inode_sync() NeilBrown
2025-01-27 1:20 ` [PATCH 3/7] nfsd: filecache: move globals nfsd_file_lru and nfsd_file_shrinker to be per-net NeilBrown
2025-01-27 1:20 ` [PATCH 4/7] nfsd: filecache: change garbage collection list management NeilBrown
2025-01-27 14:15 ` Jeff Layton
2025-01-27 1:20 ` [PATCH 5/7] nfsd: filecache: document the arbitrary limit on file-disposes-per-loop NeilBrown
2025-01-27 14:40 ` Jeff Layton
2025-01-27 1:20 ` [PATCH 6/7] nfsd: filecache: change garbage collection to a timer NeilBrown
2025-01-27 14:39 ` Jeff Layton
2025-01-27 1:20 ` [PATCH 7/7] nfsd: filecache: give disposal lock a unique class name NeilBrown
2025-01-27 14:29 ` Chuck Lever
2025-01-27 14:40 ` Jeff Layton
2025-01-28 6:37 ` [PATCH 0/7] nfsd: filecache: change garbage collection lists Dave Chinner
2025-01-28 14:27 ` Chuck Lever
2025-01-28 16:05 ` Chuck Lever
2025-01-29 21:34 ` NeilBrown
2025-02-06 2:21 ` Dave Chinner
2025-02-06 3:04 ` NeilBrown
2025-02-06 14:35 ` Chuck Lever
2025-02-05 23:04 ` NeilBrown
2025-02-06 3:02 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250127012257.1803314-1-neilb@suse.de \
--to=neilb@suse.de \
--cc=Dai.Ngo@oracle.com \
--cc=chuck.lever@oracle.com \
--cc=david@fromorbit.com \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox