Re: [PATCH net 03/24] crypto: Add 'krb5enc' hash and cipher AEAD algorithm

David Howells
2025-03-18T11:10:12Z

Geert Uytterhoeven <geert@linux-m68k.org> wrote:

> > + Combined hash and cipher support for Kerberos 5 RFC3961 simplified
> > + profile. This is required for Kerberos 5-style encryption, used by
> > + sunrpc/NFS and rxrpc/AFS.
>
> Hence shouldn't the latter (e.g. RPCSEC_GSS_KRB5) select CRYPTO_KRB5ENC
> or CRYPTO_KRB5? Or am I missing something?

SunRPC hasn't been converted to use it yet. The help text is slightly
misleading, I guess: "Kerberos 5-style encryption" is used by sunrpc/NFS
within the kernel, but not this library yet.

Unfortunately, the rxrpc/AFS patches didn't make it in due to them requiring
to go through the net-next tree, but having dependencies on both the VFS tree
and the crypto tree.

Herbert wanted the crypto patches (krb5 lib) based on his tree, which I did
and he pulled it - but then this disqualified it for also being pulled into
net-next as that would've pulled *all* the crypodev patches there as well.

For reference, the rxrpc patches can be found here:

https://web.git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-next

I intend to post them for net-next inclusion after the merge window.

David