From: Jeff Layton <jlayton@kernel.org>
To: Chuck Lever <chuck.lever@oracle.com>, Neil Brown <neilb@suse.de>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
Trond Myklebust <trondmy@kernel.org>,
Anna Schumaker <anna@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>
Cc: Sargun Dillon <sargun@meta.com>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Jeff Layton <jlayton@kernel.org>
Subject: [PATCH 0/4] nfsd: observability improvements
Date: Thu, 06 Mar 2025 07:38:12 -0500 [thread overview]
Message-ID: <20250306-nfsd-tracepoints-v1-0-4405bf41b95f@kernel.org> (raw)
While troubleshooting a performance problem internally, it became
evident that we needed tracepoints in nfsd_commit. The first patch adds
that. While discussing that, Sargun pointed out some tracepoints he
added using kprobes. Those are converted to static tracepoints here.
Lastly, this adds a new counter to the pool_stats for counting the number
of times that the kernel tried to wake a svc thread, but there were none
available. I think this may be useful info for determining whether we're
bumping up against the size of the thread pool.
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
Jeff Layton (4):
nfsd: add commit start/done tracepoints around nfsd_commit()
nfsd: add a tracepoint for nfsd_setattr
nfsd: add some stub tracepoints around key vfs functions
sunrpc: keep a count of when there are no threads available
fs/nfsd/nfs3proc.c | 3 ++
fs/nfsd/nfs4proc.c | 2 +
fs/nfsd/nfsproc.c | 2 +
fs/nfsd/trace.h | 91 ++++++++++++++++++++++++++++++++++++++++++++++
fs/nfsd/vfs.c | 31 ++++++++++++++++
include/linux/sunrpc/svc.h | 1 +
net/sunrpc/svc.c | 4 +-
net/sunrpc/svc_xprt.c | 7 ++--
8 files changed, 137 insertions(+), 4 deletions(-)
---
base-commit: 7dc86d35a5f8a7ac24b53792c704b101e5041842
change-id: 20250303-nfsd-tracepoints-c82add9155a6
Best regards,
--
Jeff Layton <jlayton@kernel.org>
next reply other threads:[~2025-03-06 12:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 12:38 Jeff Layton [this message]
2025-03-06 12:38 ` [PATCH 1/4] nfsd: add commit start/done tracepoints around nfsd_commit() Jeff Layton
2025-03-06 12:38 ` [PATCH 2/4] nfsd: add a tracepoint for nfsd_setattr Jeff Layton
2025-03-06 14:19 ` Chuck Lever
2025-03-06 12:38 ` [PATCH 3/4] nfsd: add some stub tracepoints around key vfs functions Jeff Layton
2025-03-06 14:29 ` Chuck Lever
2025-03-06 16:28 ` Jeff Layton
2025-03-06 17:40 ` Chuck Lever
2025-03-06 12:38 ` [PATCH 4/4] sunrpc: keep a count of when there are no threads available Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250306-nfsd-tracepoints-v1-0-4405bf41b95f@kernel.org \
--to=jlayton@kernel.org \
--cc=Dai.Ngo@oracle.com \
--cc=anna@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
--cc=okorniev@redhat.com \
--cc=pabeni@redhat.com \
--cc=sargun@meta.com \
--cc=tom@talpey.com \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox