From: Christian Brauner <brauner@kernel.org>
To: Chuck Lever <chuck.lever@oracle.com>,
Jeff Layton <jlayton@kernel.org>,
Amir Goldstein <amir73il@gmail.com>,
linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org,
NeilBrown <neil@brown.name>
Cc: Christian Brauner <brauner@kernel.org>
Subject: Re: [PATCH] exportfs: remove locking around ->get_parent() call.
Date: Fri, 14 Mar 2025 11:40:29 +0100 [thread overview]
Message-ID: <20250314-robust-bauzeit-5b57cf99eff0@brauner> (raw)
In-Reply-To: <174190497326.9342.9313518146512158587@noble.neil.brown.name>
On Fri, 14 Mar 2025 09:29:33 +1100, NeilBrown wrote:
> The locking around the ->get_parent() call brings no value.
> We are locking a child which is only used to find an inode and thence the
> parent inode number. All further activity involves the parent inode
> which may have several children so locking one child cannot protect the
> parent in any useful way.
>
> The filesystem must already ensure that only one 'struct inode' exists
> for a given inode, and will call d_obtain_alias() which contains the
> required locking to ensure only one dentry will be attached to that
> inode.
>
> [...]
Applied to the vfs-6.15.misc branch of the vfs/vfs.git tree.
Patches in the vfs-6.15.misc branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-6.15.misc
[1/1] exportfs: remove locking around ->get_parent() call.
https://git.kernel.org/vfs/vfs/c/64a56f635aae
prev parent reply other threads:[~2025-03-14 10:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 22:29 [PATCH] exportfs: remove locking around ->get_parent() call NeilBrown
2025-03-14 10:40 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250314-robust-bauzeit-5b57cf99eff0@brauner \
--to=brauner@kernel.org \
--cc=amir73il@gmail.com \
--cc=chuck.lever@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox