Linux NFS development
 help / color / mirror / Atom feed
From: Olga Kornievskaia <okorniev@redhat.com>
To: chuck.lever@oracle.com, jlayton@kernel.org
Cc: linux-nfs@vger.kernel.org, neilb@suse.de, Dai.Ngo@oracle.com,
	tom@talpey.com, Olga Kornievskaia <okorniev@redhat.com>
Subject: [PATCH 1/3] nfsd: fix access checking for NLM under XPRTSEC policies
Date: Fri, 21 Mar 2025 20:13:04 -0400	[thread overview]
Message-ID: <20250322001306.41666-2-okorniev@redhat.com> (raw)
In-Reply-To: <20250322001306.41666-1-okorniev@redhat.com>

When an export policy with xprtsec policy is set with "tls"
and/or "mtls", but an NFS client is doing a v3 xprtsec=tls
mount, then NLM locking calls fail with an error because
there is currently no support for NLM with TLS.

Until such support is added, allow NLM calls under TLS-secured
policy.

Fixes: 4cc9b9f2bf4d ("nfsd: refine and rename NFSD_MAY_LOCK")
Signed-off-by: Olga Kornievskaia <okorniev@redhat.com>
---
 fs/nfsd/export.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/nfsd/export.c b/fs/nfsd/export.c
index 0363720280d4..88ae410b4113 100644
--- a/fs/nfsd/export.c
+++ b/fs/nfsd/export.c
@@ -1124,7 +1124,8 @@ __be32 check_nfsd_access(struct svc_export *exp, struct svc_rqst *rqstp,
 		    test_bit(XPT_PEER_AUTH, &xprt->xpt_flags))
 			goto ok;
 	}
-	goto denied;
+	if (!may_bypass_gss)
+		goto denied;
 
 ok:
 	/* legacy gss-only clients are always OK: */
-- 
2.47.1


  reply	other threads:[~2025-03-22  0:13 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-22  0:13 [PATCH 0/3] access checking fixes for NLM under security policies Olga Kornievskaia
2025-03-22  0:13 ` Olga Kornievskaia [this message]
2025-04-07 19:44   ` [PATCH 1/3] nfsd: fix access checking for NLM under XPRTSEC policies Jeff Layton
2025-03-22  0:13 ` [PATCH 2/3] nfsd: adjust nfsd4_spo_must_allow checking order Olga Kornievskaia
2025-04-07 15:36   ` Jeff Layton
2025-04-07 15:56     ` Olga Kornievskaia
2025-04-07 15:59       ` Jeff Layton
2025-04-07 17:17         ` Olga Kornievskaia
2025-04-07 17:47           ` Jeff Layton
2025-04-07 18:02             ` Olga Kornievskaia
2025-03-22  0:13 ` [PATCH 3/3] nfsd: reset access mask for NLM calls in nfsd_permission Olga Kornievskaia
2025-03-27 23:54   ` NeilBrown
2025-03-28  0:36     ` Olga Kornievskaia
2025-03-28  1:43       ` NeilBrown
2025-03-28 12:43         ` Chuck Lever
2025-03-28 15:13         ` Olga Kornievskaia
2025-03-28 21:53           ` NeilBrown
2025-03-28 23:29             ` Tom Talpey
2025-03-30 16:17               ` Chuck Lever
2025-03-30 16:12             ` Olga Kornievskaia
2025-03-31  0:10               ` NeilBrown
2025-03-31 14:49                 ` Chuck Lever
2025-03-31 18:24                   ` Olga Kornievskaia
2025-04-01 22:24                     ` NeilBrown
2025-04-01 22:57                       ` Olga Kornievskaia
2025-04-01 23:18                         ` NeilBrown
2025-04-07 15:57             ` Jeff Layton
2025-04-08 20:40               ` Benjamin Coddington
2025-03-22 15:08 ` [PATCH 0/3] access checking fixes for NLM under security policies cel
2025-03-28  0:07 ` NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250322001306.41666-2-okorniev@redhat.com \
    --to=okorniev@redhat.com \
    --cc=Dai.Ngo@oracle.com \
    --cc=chuck.lever@oracle.com \
    --cc=jlayton@kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox