Re: [PATCH v4 02/14] sunrpc: Add a helper to derive maxpages from sv_max_mesg

Christoph Hellwig
2025-05-06T13:10:53Z

On Mon, Apr 28, 2025 at 03:36:50PM -0400, cel@kernel.org wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
>
> This page count is to be used to allocate various arrays of pages,
> bio_vecs, and kvecs, replacing the fixed RPCSVC_MAXPAGES value.
>
> The documenting comment is somewhat stale -- of course NFSv4
> COMPOUND procedures may have multiple payloads.

This helper looks fine, but please don't talk about the kvecs.
The fact that nfs currently only allocates PAGE_SIZE chunks
is home grown limitation that shouldn't be there. I have a series
trying to fix this, but it got stuck, so it might take a whіle.