Linux NFS development
 help / color / mirror / Atom feed
From: NeilBrown <neil@brown.name>
To: "Trond Myklebust" <trondmy@kernel.org>,
	"Anna Schumaker" <anna@kernel.org>,
	"Mike Snitzer" <snitzer@kernel.org>,
	"Pali Rohár" <pali@kernel.org>,
	"Vincent Mailhol" <mailhol.vincent@wanadoo.fr>
Cc: Chuck Lever <chuck.lever@oracle.com>,
	Jeff Layton <jlayton@kernel.org>,
	linux-nfs@vger.kernel.org
Subject: [PATCH 0/6] nfs_localio: fixes for races and errors from older compilers
Date: Wed, 30 Apr 2025 14:01:10 +1000	[thread overview]
Message-ID: <20250430040429.2743921-1-neil@brown.name> (raw)

Following the reports of older compilers complaining about the rcu
annotations in nfs-localio I reviewed the relevant code and found some
races and opportunities for simplification.

These patches address the various issues.  They compile with old and new
versions of gcc and don't introduce new sprase warnings.  I haven't
tested that localio, or even NFS, still work.

NeilBrown

 [PATCH 1/6] nfs_localio: use cmpxchg() to install new
 [PATCH 2/6] nfs_localio: always hold nfsd net ref with nfsd_file ref
 [PATCH 3/6] nfs_localio: simplify interface to nfsd for getting
 [PATCH 4/6] nfs_localio: change nfsd_file_put_local() to take a
 [PATCH 5/6] nfs_localio: duplicate nfs_close_local_fh()
 [PATCH 6/6] nfs_localio: protect race between nfs_uuid_put() and

             reply	other threads:[~2025-04-30  4:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-30  4:01 NeilBrown [this message]
2025-04-30  4:01 ` [PATCH 1/6] nfs_localio: use cmpxchg() to install new nfs_file_localio NeilBrown
2025-04-30 22:21   ` Mike Snitzer
2025-04-30  4:01 ` [PATCH 2/6] nfs_localio: always hold nfsd net ref with nfsd_file ref NeilBrown
2025-04-30  4:01 ` [PATCH 3/6] nfs_localio: simplify interface to nfsd for getting nfsd_file NeilBrown
2025-04-30  4:01 ` [PATCH 4/6] nfs_localio: change nfsd_file_put_local() to take a pointer to __rcu struct NeilBrown
2025-04-30  4:01 ` [PATCH 5/6] nfs_localio: duplicate nfs_close_local_fh() NeilBrown
2025-04-30  4:01 ` [PATCH 6/6] nfs_localio: protect race between nfs_uuid_put() and nfs_close_local_fh() NeilBrown
2025-04-30 17:34   ` Mike Snitzer
2025-04-30 20:20     ` Mike Snitzer
2025-04-30 22:16       ` NeilBrown
2025-04-30 22:12     ` NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250430040429.2743921-1-neil@brown.name \
    --to=neil@brown.name \
    --cc=anna@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=jlayton@kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=mailhol.vincent@wanadoo.fr \
    --cc=pali@kernel.org \
    --cc=snitzer@kernel.org \
    --cc=trondmy@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox