Re: [PATCH v1 0/4] Remove svc_rqst :: rq_vec

Jeff Layton
2025-05-07T15:26:33Z

On Wed, 2025-05-07 at 10:07 -0400, cel@kernel.org wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
>
> I intend to insert these into the series that expands the maximum
> r/wsize, once they are reviewed.
>
> Testing has shown no correctness issues, but some unexpected
> performance variation that I still need to chase down.
>

Interesting.

> Chuck Lever (4):
> NFSD: Use rqstp->rq_bvec in nfsd_iter_read()
> NFSD: De-duplicate the svc_fill_write_vector() call sites
> NFSD: Use rqstp->rq_bvec in nfsd_iter_write()
> SUNRPC: Remove svc_rqst :: rq_vec
>
> fs/nfsd/nfs3proc.c | 5 +---
> fs/nfsd/nfs4proc.c | 8 ++---
> fs/nfsd/nfsproc.c | 9 ++----
> fs/nfsd/vfs.c | 61 +++++++++++++++++++++++++++-----------
> fs/nfsd/vfs.h | 10 +++----
> include/linux/sunrpc/svc.h | 3 +-
> net/sunrpc/svc.c | 33 ++++++++++-----------
> 7 files changed, 71 insertions(+), 58 deletions(-)

Either way, this seems like a good simplification and cleanup.

Reviewed-by: Jeff Layton <jlayton@kernel.org>